1915397 - fix some coverity issues

Status: ASSIGNED

(Thunderbird :: General, defect)

Description

[Magnus Melin [:mkmelin]]

This bug is to track some issues found by coverity.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix resource leak in nsImapNamespaceList::GetNamespaceForFolder. r=BenC

CID: 1534793

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix unitialized scalar field in MboxCompactor. r=BenC

CID: 1600522

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - remove logically dead code in nsMsgDBView::​SecondaryCompare. r=welpy-cw

CID: 1539175

For id the code bails out already at https://searchfox.org/comm-central/rev/498e1dfdb84c8c9fcc4a0afc20acc9bd1f061500/mailnews/base/src/nsMsgDBView.cpp#4189

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - Fix dereference before null check in nsImapIncomingServer::GetMsgFolderFromURI. r=BenC

CID: 1537418

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - Fix resource leak in nsImapServerResponseParser::xmailboxinfo_data. r=gds

CID: 450306

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix uninitialized scalar variable in nsCMSMessage::​CommonVerifySignature. r=kaie

CID: 1616909

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - Fix resource leak in EncodeImap. r=BenC

CID: 1537740

Comment 8

[Magnus Melin [:mkmelin]]

(Checking needed for the ones reviews, these are independent changesets)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/03abb6a12276
fix unitialized scalar field in MboxCompactor. r=BenC
https://hg.mozilla.org/comm-central/rev/228924722b20
remove logically dead code in nsMsgDBView::​SecondaryCompare. r=welpy-cw
https://hg.mozilla.org/comm-central/rev/bfd7b7ad3c61
Fix resource leak in nsImapServerResponseParser::xmailboxinfo_data. r=gds
https://hg.mozilla.org/comm-central/rev/3037827f6650
fix uninitialized scalar variable in nsCMSMessage::​CommonVerifySignature. r=kaie

Comment 10

[betterbird.project+18]

Did you mean to land changes to python/rocbuild/rocbuild/rust.py?
https://hg.mozilla.org/comm-central/rev/03abb6a12276599d37dd2dec725dee19e8582922#l2.12

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dee6f7501d5e
Backed out changeset 03abb6a12276 .
https://hg.mozilla.org/comm-central/rev/f4b49deb8b6e
fix unitialized scalar field in MboxCompactor. r=BenC DONTBUILD

Comment 12

[Magnus Melin [:mkmelin]]

^^^ Re-landed without the accidentally included chunk from an unrelated bitrotted patch.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c990397c5a52
fix resource leak in nsImapNamespaceList::GetNamespaceForFolder. r=BenC

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1ddbf5d80311
Fix dereference before null check in nsImapIncomingServer::GetMsgFolderFromURI. r=BenC

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/98bdce7720f6
Fix resource leak in EncodeImap. r=BenC

Comment 16

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix unused value in nsMimeBaseEmitter::MimeGetStringByID. r=#thunderbird-reviewers

CID: 1260153

Comment 17

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix resource leak in MimeMultipartAlternative_flush_children. r=#thunderbird-reviewers

CID: 1537771

Comment 18

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix resource leaks in mime_parse_stream_complete. r=#thunderbird-reviewers

CID: 1137489
CID: 1137488

Comment 19

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix resource leak in MimeMultipartSigned_emit_child(). r=#thunderbird-reviewers

CID: 450615

Comment 20

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix resource leak in morkFactory::​MakeHeap(). r=#thunderbird-reviewers

CID: 221061

Comment 21

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix uninitialized scalar fields in nsLocalMailCopyState::​nsLocalMailCopyState(). r=BenC

CID: 1137619

Comment 22

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix uninitialized pointer fields in nsImapServerResponseParser::​nsImapServerResponseParser(). r=#thunderbird-reviewers

CID: 1137607

Comment 23

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix uninitialized scalar field in nsImapUrl::​nsImapUrl(). r=babolivier

CID: 1137605

Comment 24

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix uninitialized pointer fields in nsLocalMoveCopyMsgTxn::​nsLocalMoveCopyMsgTxn(). r=#thunderbird-reviewers

CID: 1137594

Comment 25

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix uninitialized scalar field in nsMsgMailboxParser::​nsMsgMailboxParser(). r=babolivier

CID: 1137592

Comment 26

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix uninitialized scalar field in nsParseNewMailState::​nsParseNewMailState(). r=#thunderbird-reviewers

CID: 1137591

Comment 27

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix uninitialized pointer field in MimePgpeData::​MimePgpeData(). r=kaie

CID: 1137590

Comment 28

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix uninitialized scalar field in nsPgpMimeProxy::​nsPgpMimeProxy(). r=kaie

CID: 1137589

Comment 29

[Magnus Melin [:mkmelin]]

Attachment: Bug 1915397 - fix uninitialized scalar fields in mime_stream_data::​mime_stream_data(). r=#thunderbird-reviewers

CID: 1137614

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/12f15839996d
fix uninitialized scalar field in nsImapUrl::​nsImapUrl(). r=thunderbird-reviewers,babolivier
https://hg.mozilla.org/comm-central/rev/372c4f46bd1a
fix uninitialized pointer fields in nsLocalMoveCopyMsgTxn::​nsLocalMoveCopyMsgTxn(). r=tobyp
https://hg.mozilla.org/comm-central/rev/126f7de16b03
fix uninitialized scalar field in nsMsgMailboxParser::​nsMsgMailboxParser(). r=thunderbird-reviewers,babolivier
https://hg.mozilla.org/comm-central/rev/266af6b63026
fix uninitialized scalar field in nsParseNewMailState::​nsParseNewMailState(). r=john.bieling
https://hg.mozilla.org/comm-central/rev/c306f1b7067d
fix uninitialized pointer field in MimePgpeData::​MimePgpeData(). r=kaie
https://hg.mozilla.org/comm-central/rev/306a51c14688
fix uninitialized scalar field in nsPgpMimeProxy::​nsPgpMimeProxy(). r=kaie
https://hg.mozilla.org/comm-central/rev/36ea718884e5
fix uninitialized scalar fields in mime_stream_data::​mime_stream_data(). r=tobyp