1915555 - Text in CSS variable tooltip does not have enough contrast in dark mode

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

In dark mode, the tooltip background is different from the rules view one, and the color that we use don't have enough contrast on such background

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1912006

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1915555 - [devtools] Fix color contrast in CSS variable tooltip in dark-mode. r=#devtools-reviewers.

dquote>
dquote> The default dark-mode tooltip background is lighter than
dquote> the tooltip, which was causing some low contrast issues.
dquote> A solution might have been to define specific colors that
dquote> would work against such background, but this would be complex,
dquote> and brittle IMO.
dquote> The simpler solution is to make the tooltip background the
dquote> same as the rules view background, where we know our colors
dquote> have enough contrast, and introducing new ones have a higher
dquote> chance of having good contrast as it is upfront, in comparison
dquote> to the tooltip that you have to trigger.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1daae70b0551
[devtools] Fix color contrast in CSS variable tooltip in dark-mode. r=devtools-reviewers,bomsy.

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1daae70b0551