Closed Bug 2033782 Opened 5 months ago Closed 5 months ago

@container tooltip text doesn't have enough contrast in dark mode

Categories

(DevTools :: Inspector: Rules, defect, P3)

Product:
DevTools
Component:
Inspector: Rules
Type:
defect

Tracking

(firefox151 fixed, firefox152 fixed)

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox151 --- fixed
firefox152 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 2033782 - [devtools] Fix container query tooltip contrast in dark mode. r=#devtools.
48 bytes, text/x-phabricator-request
Details | Review
Bug 2033782 - [devtools] Fix container query tooltip contrast in dark mode. .
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review

Like in Bug 1915555, In dark mode, the tooltip background is different from the rules view one, and the color that we use don't have enough contrast on such background

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P3
Pushed by nchevobbe@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/cac2e8f4bb1d https://hg.mozilla.org/integration/autoland/rev/089f0fba6917 [devtools] Fix container query tooltip contrast in dark mode. r=devtools-reviewers,bomsy.

https://hg.mozilla.org/mozilla-central/rev/089f0fba6917

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch

Authored by https://github.com/nchevobbe
https://github.com/mozilla/enterprise-firefox/commit/cac2e8f4bb1d83dc4eceb0b60f4cd66d1a921cce
[enterprise-main] Bug 2033782 - [devtools] Fix container query tooltip contrast in dark mode. r=devtools-reviewers,bomsy.

Attachment #9574024 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Text in part of the UI that will be visible as part of 150 has accessibility issue (failing text contrast)
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: no
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing: -
  • Risk associated with taking this patch: low
  • Explanation of risk level: couple lines devtools-only CSS patch
  • String changes made/needed?: -
  • Is Android affected?: no
Attachment #9574024 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: