191557 - Header of user prefs file is malformed

Status: RESOLVED DUPLICATE of bug 193638

(Core :: Preferences: Backend, defect)

Description

[Ben Bucksch (:BenB)]

prefs.js containes the following generated header:

# Mozilla User Preferences
// This is a generated file!

Appearently, this has pretty much always been this way. However,
* This is malformed. According to the JS reference
<http://devedge.netscape.com/library/manuals/2000/javascript/1.5/reference/comment.html#1066617>,
JS comments are like C++ comments: // or /* */. Not "#", which is Unix
Perl/configfile-style.
* Zach Lipton reports that this causes an error in a 1.0.2 Mac OS X build he
created. He wrote:
"I get the following error on launch:
Configuration Warning
An error occurred reading the startup configuration file. Please contact
your administrator.  line 335: SyntaxError: illegal character. # Mozilla
User Preferences"

Comment 1

[Ben Bucksch (:BenB)]

Attachment: Patch, Version 1

Prevents creating new buggy prefs.js files. Note sure, if it is also used to
regenerate prefs.js, so taht existing profiles are fixed automatically.

Comment 2

[Conrad Carlen (not reading bugmail)]

Believe it or not, that's on purpose:
http://lxr.mozilla.org/seamonkey/source/modules/libpref/src/prefapi.cpp#398

Notice the reporter said
line 335: SyntaxError: illegal character. # Mozilla
User Preferences"

If that occured on line 335, the file was corrupted.

I think this is invalid.

Comment 3

[Ben Bucksch (:BenB)]

Funny. This bug as reported is then probably invalid, yes.

Strange error still, because the reportedly bad line seems to be correct, then.
Maybe there was some malformed whitespace char in the file? *shrug*

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 205597 has been marked as a duplicate of this bug. ***

Comment 5

[OstGote!]

This is clear a dupe of Bug 193638, isn't it?

>Configuration Warning
>An error occurred reading the startup configuration file. Please contact
>your administrator.  line 335: SyntaxError: illegal character. # Mozilla
>User Preferences"

Comment 6

[Ben Bucksch (:BenB)]

*** This bug has been marked as a duplicate of 193638 ***