Closed Bug 1915741 Opened 1 year ago Closed 9 months ago

Add logic to create Taskbar Tab

Categories

(Firefox :: Shell Integration, enhancement, P3)

Product:
Firefox
Component:
Shell Integration
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
141 Branch
Tracking Flags:
Tracking Status
firefox141 --- fixed

People

(Reporter: nrishel, Assigned: nrishel)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidedi])

Attachments

(2 files, 1 obsolete file)

Bug 1915741 - Split out page action handling into a new file, and make `TaskbarTabs.sys.mjs` an async interface to an initialized Taskbar Tabs system. r=mossop,cdupuis,mpohle
48 bytes, text/x-phabricator-request
Details | Review
Bug 1915741 - Post: Rename `TaskbarTabUI` to `TaskbarTabsChrome` to normalize to `Tabs` and disambiguate from the content from `TaskbarTabsPageAction`. r=cdupuis,mpohle
48 bytes, text/x-phabricator-request
Details | Review

We need a means of creating and remembering that a Taskbar Tab was created, recall it's scope, and be aware of it's identifier when launched.

See Also: → 1915742
Priority: -- → P3
Assignee: nobody → erchen
Attachment #9441476 - Attachment description: WIP: Bug 1915741 - [P3] adding taskbar tab pinning functionality → Bug 1915741 - [P3] adding taskbar tab pinning functionality r=nrishel
Attachment #9441476 - Attachment description: Bug 1915741 - [P3] adding taskbar tab pinning functionality r=nrishel → WIP: Bug 1915741 - [P3] adding taskbar tab pinning functionality r=nrishel
Attachment #9441476 - Attachment description: WIP: Bug 1915741 - [P3] adding taskbar tab pinning functionality r=nrishel → Bug 1915741 - [P3] adding taskbar tab pinning functionality r=nrishel
Attachment #9441476 - Attachment description: Bug 1915741 - [P3] adding taskbar tab pinning functionality r=nrishel → WIP: Bug 1915741 - [P3] adding taskbar tab pinning functionality r=nrishel
Attachment #9441476 - Attachment description: WIP: Bug 1915741 - [P3] adding taskbar tab pinning functionality r=nrishel → Bug 1915741 - [P3] adding taskbar tab pinning functionality r=nrishel
Assignee: ericchen647 → nrishel
Status: NEW → ASSIGNED
Attachment #9441476 - Attachment is obsolete: true
Pushed by nrishel@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/95997541b200 https://hg.mozilla.org/integration/autoland/rev/64ce877743d8 Split out page action handling into a new file, and make `TaskbarTabs.sys.mjs` an async interface to an initialized Taskbar Tabs system. r=mossop,cdupuis https://github.com/mozilla-firefox/firefox/commit/ce9f14e71855 https://hg.mozilla.org/integration/autoland/rev/89a2ca9ffbeb Post: Rename `TaskbarTabUI` to `TaskbarTabsChrome` to normalize to `Tabs` and disambiguate from the content from `TaskbarTabsPageAction`. r=cdupuis

https://hg.mozilla.org/mozilla-central/rev/64ce877743d8
https://hg.mozilla.org/mozilla-central/rev/89a2ca9ffbeb

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox141: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch
Pushed by nrishel@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/238eb9d862a2 https://hg.mozilla.org/integration/autoland/rev/f44a88b1745b Split out page action handling into a new file, and make `TaskbarTabs.sys.mjs` an async interface to an initialized Taskbar Tabs system. r=mossop,cdupuis https://github.com/mozilla-firefox/firefox/commit/050a7ed8c2f4 https://hg.mozilla.org/integration/autoland/rev/60887aa9e2fc Post: Rename `TaskbarTabUI` to `TaskbarTabsChrome` to normalize to `Tabs` and disambiguate from the content from `TaskbarTabsPageAction`. r=cdupuis

Backed out for causing bc failures @ browser_taskbarTabs_windowManager

Flags: needinfo?(nrishel)
Pushed by nrishel@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/faab3bde77ab https://hg.mozilla.org/integration/autoland/rev/231b520f9c8d Split out page action handling into a new file, and make `TaskbarTabs.sys.mjs` an async interface to an initialized Taskbar Tabs system. r=mossop,cdupuis https://github.com/mozilla-firefox/firefox/commit/a23c48255e00 https://hg.mozilla.org/integration/autoland/rev/58da6ad4a12d Post: Rename `TaskbarTabUI` to `TaskbarTabsChrome` to normalize to `Tabs` and disambiguate from the content from `TaskbarTabsPageAction`. r=cdupuis

Backed out for causing XPC failures @test_taskbarTabs_pin.js and Marionette failures @test_no_errors_clean_profile.py

Pushed by nrishel@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/32f5ec252581 https://hg.mozilla.org/integration/autoland/rev/c04e3a2b7533 Split out page action handling into a new file, and make `TaskbarTabs.sys.mjs` an async interface to an initialized Taskbar Tabs system. r=mossop,cdupuis https://github.com/mozilla-firefox/firefox/commit/9816c0d8f3ef https://hg.mozilla.org/integration/autoland/rev/5c01dca3b06f Post: Rename `TaskbarTabUI` to `TaskbarTabsChrome` to normalize to `Tabs` and disambiguate from the content from `TaskbarTabsPageAction`. r=cdupuis
Flags: needinfo?(nrishel)
QA Whiteboard: [qa-triage-done-c142/b141]
Duplicate of this bug: 1934950
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: