1915742 - Add Taskbar Tabs launch handling

Status: RESOLVED FIXED

(Firefox :: Shell Integration, enhancement, P3)

Description

[Nick Rishel [:nrishel]]

We need to handle when a Taskbar Tab has been opened by it's Taskbar Icon.

Comment 1

[Nick Rishel [:nrishel]]

Attachment: Bug 1915742 - Pre: Convert to Unix style line endings. r=mpohle

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1915742 - Update Taskbar Tabs command line handling to use the Taskbar Tabs window manager instead of creating the window directly. r=mossop,cdupuis,mpohle

Because we reuse -new-window for Taskbar Tabs shortcuts for fallback when Taskbar Tabs are disabled, command-line-handler was modified from m-taskbar-tabs to l-taskbar-tabs to ensure we preempt BrowserContentHandler which consumes -new-window.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7e655941f402
https://hg.mozilla.org/integration/autoland/rev/2a726db142e5
Update Taskbar Tabs command line handling to use the Taskbar Tabs window manager instead of creating the window directly. r=cdupuis

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a6ad5b24656c
https://hg.mozilla.org/integration/autoland/rev/c8869c69b70c
Revert "Bug 1915742 - Update Taskbar Tabs command line handling to use the Taskbar Tabs window manager instead of creating the window directly. r=cdupuis" for causing mochitests failures in browser_taskbarTabs_pageAction.js.

Comment 5

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_taskbarTabs_pageAction.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/taskbartabs/test/browser/browser_taskbarTabs_pageAction.js | Exception thrown - at resource://testing-common/sinon-7.2.7.js:3605 - TypeError: Attempted to wrap pinTaskbarTab which is already wrapped

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9d50502a393f
https://hg.mozilla.org/integration/autoland/rev/c63c2baa904c
Update Taskbar Tabs command line handling to use the Taskbar Tabs window manager instead of creating the window directly. r=cdupuis

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9210ce5271b0
https://hg.mozilla.org/integration/autoland/rev/a75d340da158
Revert "Bug 1915742 - Update Taskbar Tabs command line handling to use the Taskbar Tabs window manager instead of creating the window directly. r=cdupuis" for causing bc failures @ browser_taskbarTabs_windowManager.js

Comment 8

[amarc]

Backed out for causing bc failures @ browser_taskbarTabs_windowManager

• Backout link
• Push with failures
• Failure Log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6c517b0c205d
https://hg.mozilla.org/integration/autoland/rev/765bd14a803e
Update Taskbar Tabs command line handling to use the Taskbar Tabs window manager instead of creating the window directly. r=cdupuis

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/14d262bb17c6
https://hg.mozilla.org/integration/autoland/rev/ca42e3a0e39c
Revert "Bug 1915742 - Update Taskbar Tabs command line handling to use the Taskbar Tabs window manager instead of creating the window directly. r=cdupuis" for causing XPC failures @test_taskbarTabs_pin.js and Marionette failures @test_no_errors_clean_profile.py

Comment 11

[pstanciu]

Backed out for causing XPC failures @test_taskbarTabs_pin.js and Marionette failures @test_no_errors_clean_profile.py

• https://hg.mozilla.org/integration/autoland/rev/ca42e3a0e39ccea55a166c68f47e7c53c526d3e9
• Push with failures
• XPC Failure Log
• Push with failures
• Marionette Failure Log

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b279e4a76c35
https://hg.mozilla.org/integration/autoland/rev/98ee76ee0010
Update Taskbar Tabs command line handling to use the Taskbar Tabs window manager instead of creating the window directly. r=cdupuis

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/98ee76ee0010