1915762 - Introduce getFaviconDataURL() into nsIFaviconService

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Daisuke Akatsuka (:daisuke)]

This is a follow-up of bug 1894633.
We have a method nsIFaviconService.getFaviconDataForPage(), but it returns the favicon data as an array.
Not do that, it will be helpful if we can get favicon data as data URL.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Introduce nsIFaviconService::getFaviconForPage()

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: WIP: Bug 1915762: Apply getFaviconForPage() instaed of getFaviconURLForPage()

Depends on D224899

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Apply getFaviconForPage() in PageIconProtocolHandler

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Apply getFaviconForPage() in nsAlertsService

Depends on D239487

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Apply getFaviconForPage() in AboutReader

Depends on D239488

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Apply getFaviconForPage() in nsGNOMEShellSearchProvider

Comment 7

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Apply getFaviconForPage() in WinUtils

Comment 8

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Apply getFaviconForPage() in PlacesUtils

Depends on D240566

Comment 9

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Apply getFaviconForPage() in TopSites

Depends on D239489

Comment 10

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Remove faviconUrl of TabTarget in cdp

Depends on D241350

Comment 11

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Apply getFaviconForPage() for tests

Depends on D241351

Comment 12

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Remove getFaviconurlForPage() and getFaviconDataForPage() from nsIFaviconService

Depends on D241352

Comment 13

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Remove PlacesUtils.promiseFaviconData()

Depends on D241353

Comment 14

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1915762: Unify helper function to get favicon data

Depends on D241354

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/821fd5e8b048
Introduce nsIFaviconService::getFaviconForPage() r=mak

Comment 16

[agoloman]

Backed out for causing build bustages @nsFaviconService.cpp.

• Backout link
• Push with failures
• Failure Log

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dca071d63885
Introduce nsIFaviconService::getFaviconForPage() r=mak

Comment 18

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/dca071d63885

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9955e42e749b
Apply getFaviconForPage() in PageIconProtocolHandler r=mak
https://hg.mozilla.org/integration/autoland/rev/b290501f5832
Apply getFaviconForPage() in nsGNOMEShellSearchProvider r=mak
https://hg.mozilla.org/integration/autoland/rev/fb2232e5f3b5
Apply getFaviconForPage() in WinUtils r=win-reviewers,mak,handyman
https://hg.mozilla.org/integration/autoland/rev/ec8a0553d97a
Apply getFaviconForPage() in PlacesUtils r=mak
https://hg.mozilla.org/integration/autoland/rev/5e38449cd4d9
Apply getFaviconForPage() in AboutReader r=mak
https://hg.mozilla.org/integration/autoland/rev/8a7b0b87a0ef
Apply getFaviconForPage() in TopSites r=mak
https://hg.mozilla.org/integration/autoland/rev/677c35e884d3
Remove faviconUrl of TabTarget in cdp r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/5d74e419e249
Apply getFaviconForPage() for tests r=migration-reviewers,mak,mconley
https://hg.mozilla.org/integration/autoland/rev/964a29c9a07a
Remove getFaviconurlForPage() and getFaviconDataForPage() from nsIFaviconService r=mak
https://hg.mozilla.org/integration/autoland/rev/05691232a461
Remove PlacesUtils.promiseFaviconData() r=sync-reviewers,profiler-reviewers,devtools-reviewers,mak,nchevobbe,canaltinova,markh
https://hg.mozilla.org/integration/autoland/rev/5c7edcb3b105
Unify helper function to get favicon data r=mak

Comment 20

[Cristian Tuns]

Backed out for causing node failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:251: error TS1005: ';' expected.
  TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:253: error TS1128: Declaration or statement expected.
  TEST-UNEXPECTED-FAIL | typescript | performance | devtools/client/performance-newtypes/gecko.d.ts:312: error TS1128: Declaration or statement expected.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6840871c03e
Apply getFaviconForPage() in PageIconProtocolHandler r=mak
https://hg.mozilla.org/integration/autoland/rev/579ec95712da
Apply getFaviconForPage() in nsGNOMEShellSearchProvider r=mak
https://hg.mozilla.org/integration/autoland/rev/75fb2711fae9
Apply getFaviconForPage() in WinUtils r=win-reviewers,mak,handyman
https://hg.mozilla.org/integration/autoland/rev/9fc54f4aadf6
Apply getFaviconForPage() in PlacesUtils r=mak
https://hg.mozilla.org/integration/autoland/rev/256fe5799418
Apply getFaviconForPage() in AboutReader r=mak
https://hg.mozilla.org/integration/autoland/rev/2f84634f5d11
Apply getFaviconForPage() in TopSites r=mak
https://hg.mozilla.org/integration/autoland/rev/bc521c66b8d9
Remove faviconUrl of TabTarget in cdp r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/bfd6b454507b
Apply getFaviconForPage() for tests r=migration-reviewers,mak,mconley
https://hg.mozilla.org/integration/autoland/rev/2e085f3d1dd1
Remove getFaviconurlForPage() and getFaviconDataForPage() from nsIFaviconService r=mak
https://hg.mozilla.org/integration/autoland/rev/0068977ee271
Remove PlacesUtils.promiseFaviconData() r=sync-reviewers,profiler-reviewers,devtools-reviewers,mak,nchevobbe,canaltinova,markh
https://hg.mozilla.org/integration/autoland/rev/9779ccb4c6ad
Unify helper function to get favicon data r=mak

Comment 22

[amarc]

https://hg.mozilla.org/mozilla-central/rev/a6840871c03e
https://hg.mozilla.org/mozilla-central/rev/579ec95712da
https://hg.mozilla.org/mozilla-central/rev/75fb2711fae9
https://hg.mozilla.org/mozilla-central/rev/9fc54f4aadf6
https://hg.mozilla.org/mozilla-central/rev/256fe5799418
https://hg.mozilla.org/mozilla-central/rev/2f84634f5d11
https://hg.mozilla.org/mozilla-central/rev/bc521c66b8d9
https://hg.mozilla.org/mozilla-central/rev/bfd6b454507b
https://hg.mozilla.org/mozilla-central/rev/2e085f3d1dd1
https://hg.mozilla.org/mozilla-central/rev/0068977ee271
https://hg.mozilla.org/mozilla-central/rev/9779ccb4c6ad

Comment 23

[Ryan VanderMeulen [:RyanVM]]

Should this bug still be open?

Comment 24

[Daisuke Akatsuka (:daisuke)]

Oh, I will close. Thanks Ryan!