Closed Bug 1915766 Opened 2 months ago Closed 1 month ago

Add a Nimbus variable that hides the Suggest UI

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

Attachments

(1 file)

The new potential exposures implementation relies on Suggest, but Suggest is currently limited to U.S. users, and we'd like the ability to enable potential exposures in any region and locale. The only part of Suggest that's visible to users and not behind some feature gate or other pref is the settings UI (I think). If we add a Nimbus variable that hides the UI, then we can set it plus quickSuggestEnabled to use potential exposures (and any other under-the-hood part of Suggest) outside the U.S.

See Also: → 1916873

This makes browser_search_firefoxSuggest.js more realistic by installing a
Nimbus experiment to change the Suggest scenario instead of manually setting the
scenario via the helper function. (The "scenario" just means whether Suggest is
enabled or not, basically. "history" means it's not enabled; "offline" and
"online" mean it's enabled. The difference between the latter two is that in
"online" the user has opted in to the Merino server, and that only means one of
the Suggest prefs is true instead of false.)

I noticed browser_privacy_firefoxSuggest.js does not check the visibility of
its Suggest section at all, so I added similar tasks to it and factored out the
common helpers into head.js.

Depends on D221097

Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c8e97bda463e Add a Nimbus variable that hides the Suggest UI. r=daisuke,settings-reviewers,mossop
Regressions: 1918273
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: