Closed Bug 1916873 Opened 1 month ago Closed 26 days ago

Allow Suggest to be safely enabled in non-Suggest locales

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We'd like the ability to run potential exposure experiments in any locale. With potential exposure suggestions now implemented in the Rust Suggest component, we need to be able to safely enable Suggest in non-Suggest locales. Aside from bug 1915766, which is about hiding the Suggest UI, that's mostly not a problem. The only thing is that currently some of the secondary Suggest prefs default to true in non-Suggest locales. That normally doesn't matter since the main feature-gate pref is false in those locales, so those secondary prefs are ignored. But now that we want to set the feature gate to true in experiments, those prefs should default to false.

In addition to addressing the bug, this also adds some exposure tests to make
sure that they can be triggered in non-Suggest locales and that non-exposure
suggestions are not triggered.

Depends on D220359

Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a0e96e51a33b Allow Suggest to be safely enabled in non-Suggest locales. r=daisuke,settings-reviewers,mossop
Status: ASSIGNED → RESOLVED
Closed: 26 days ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: