1916008 - Separate signal handling for AudioTrimmer and MediaChangeMonitor creation

Status: RESOLVED FIXED

(Core :: Audio/Video, task, P1)

Description

[C.M.Chang[:chunmin]]

For bug 1891082, the creation of AudioTrimmer and MediaChangeMonitor will need to rely on separate variables instead of a single NoWrapper::mDontUseWrapper variable.

Previously, the MediaChangeMonitor was only used for video codecs like H264 and VPX, so the conditional creation of AudioTrimmer and MediaChangeMonitor can rely on the same variable by checking whether the codec is audio or video. However, the patches in bug 1891082 will make MediaChangeMonitor used for AAC as well, so using two separate variables checking the need to create AudioTrimmer and MediaChangeMonitor is required. Otherwise, after MediaChangeMonitor is created for AAC, the NoWrapper::mDontUseWrapper will be set, and no AudioTrimmer will be created.

Additionally, by two variables signalling creating AudioTrimmer and MediaChangeMonitor separately, MediaChangeMonitor for AAC can only be set for WebCodecs' usage, without risking breaking other use cases for this change.

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1916008 - Separate signal handling for AudioTrimmer and MediaChangeMonitor creation

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1916008 - Add ToString() for CreateDecoderParams

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1916008 - Log CreateDecoderParams in MediaChangeMonitor

Depends on D220963

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1916008 - Remove unused parameters in AudioTrimmer

Depends on D220964

Comment 5

[C.M.Chang[:chunmin]]

Attachment: Bug 1916008 - Init mEncryptedCustomIdent in CreateDecoderParams

Fix WARNING: constructor does not initialize these fields: mEncryptedCustomIdent

Depends on D220753

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e59dbd7cdffd
Add ToString() for CreateDecoderParams r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/9962423787fd
Log CreateDecoderParams in MediaChangeMonitor r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/32f7f86bdedc
Remove unused parameters in AudioTrimmer r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/fef9517a08ae
Separate signal handling for AudioTrimmer and MediaChangeMonitor creation r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/dc465849474d
Init mEncryptedCustomIdent in CreateDecoderParams r=media-playback-reviewers,padenot

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e59dbd7cdffd
https://hg.mozilla.org/mozilla-central/rev/9962423787fd
https://hg.mozilla.org/mozilla-central/rev/32f7f86bdedc
https://hg.mozilla.org/mozilla-central/rev/fef9517a08ae
https://hg.mozilla.org/mozilla-central/rev/dc465849474d