1916074 - Query user whether they want to install engine when using contextual search

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P4)

Description

[Dale Harvey (:daleharvey)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1893071 changes the behaviour to auto install search engines triggered via contextual search. In the initial implementation we discussed whether we should add some flow to query whether the user wants the engine installed or not.

Comment 1

[Mark Banner (:standard8)]

As an additional consideration, we should take into account what happens in private browsing mode if the user takes the contextual search option - especially if we decide not to prompt the user in the normal case. Automatically adding an engine in normal mode may be fine, but private mode may be more unexpected, as it may equate to "browsing history".

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1916074 - Prompt users to install opensearch engines

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1916074 - Ask users if they want to install engines they use. r=Standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b12f223fb39
Ask users if they want to install engines they use. r=Standard8,urlbar-reviewers,fluent-reviewers

Comment 5

[Atila Butkovits]

Backed out for causing failures atr browser_contextualsearch.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/49e516f7eafb62279d2322f15459fc7ffe8bda88

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7b12f223fb39300333a071a099aace9cc09e502d&selectedTaskRun=BzUgflulRaCYH9HsRLD1wQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=483639984&repo=autoland&lineNumber=10705

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8528ab64729a
Ask users if they want to install engines they use. r=Standard8,urlbar-reviewers,fluent-reviewers

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/8528ab64729a

Comment 8

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed on 135.0a1 across OSes. After performing a few searches via contextual search, a infobar is displayed so that engines used can be added to the search engines list.