1916153 - [Menu Redesign] Remove extension promotion information

Status: VERIFIED FIXED

(Fenix :: Toolbar, task, P2)

Description

[raj.azharuddin]

Attachment: Screenshot_2024-09-02-12-31-09-29_984e1414ae90666a90f12ff17ec14a7f.jpg

User Agent: Mozilla/5.0 (Android 14; Mobile; rv:131.0) Gecko/131.0 Firefox/131.0

Steps to reproduce:

Enable new menu redesign
Click 3 dot menu and then extensions
You will see a big banner or promo or ad stating what are extensions.
As a long time user and people like me, we already know what are extensions and this we don't need this promo.

Expected results:

You could show this banner to new users or users who have not signed in..but once you sign in they should not see this

Comment 1

[Chris Peterson [:cpeterson]]

Thanks. Bug 1909147 will fix this. This banner will only be shown to users who have no extensions.

Comment 2

[Iorga Gabriel]

It was implemented in this pr (https://phabricator.services.mozilla.com/D221488).

Comment 3

[Aarjav [:aarjav]]

The extension's promotion information should be hidden when the user adds the first extensions from the recommended list.

STR:

• Go to the extensions sub-menu with no extensions installed.
• Install an extension from the recommended list in the sub-menu.

Expected:

• Show that the added extension is being shown in the extensions sub-menu.
• Hide/remove the extension promotion information

Actual

• the added extension is being shown in the extensions sub-menu.
• The extension promotion information is also being shown.

Comment 4

[Iorga Gabriel]

Attachment: Bug 1916153 - [Menu Redesign] Remove extension promotion information

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e59c25e82fab
[Menu Redesign] Remove extension promotion information r=android-reviewers,petru

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e59c25e82fab

Comment 7

[Vasilica Tamas QA [:vtamas]]

Attachment: ExtensionPromotionInformation.mp4

Tested this implementation on Firefox Nightly 133 (2024-10-09) using a Samsung Galaxy S24 Ultra (Android 14) and Xiaomi 12 T (android 12). Confirming that the extension promotion information is no longer displayed in Extensions sub-meniu after installing at least one extension.

Comment 8

[Vasilica Tamas QA [:vtamas]]

Attachment: DisabledExtension.mp4

But, should the extension promotion information be displayed if there are extensions installed but all are disabled?

Comment 9

[Aarjav [:aarjav]]

That is correct, it should still show the promotion/empty state when all extensions have been disabled. But in this case the strings are a bit different. I have created a separate ticket for this. - > Bug 1923874

Comment 10

[Vasilica Tamas QA [:vtamas]]

Thanks @aarjav for your answer! Considering that the followup bug is tracked in Bug 1923874 we can mark this one as Verified.