1923874 - [Menu Redesign] Show extension promotion with updated strings when all installed extensions have been disabled

Status: VERIFIED FIXED

(Fenix :: Toolbar, task, P1)

Description

[Aarjav [:aarjav]]

Figma Link: https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/%5B%5D-Menu-Redesign?node-id=14804-178947&t=YBcTSQ5Fd5SNqEGX-4

This is a release blocker.

Comment 1

[Arturo Mejia [:amejia]]

Chatting with Gabriel we discovered the banner was not showing, because we also have built-in extensions (Which are installed by Firefox and user may not be aware) like reader view or web compact reporter. Gabriel is trying to address the issue by also excluding built-in extensions from validation to show the banner.

Comment 2

[Iorga Gabriel]

Attachment: Bug 1923874 - [Menu Redesign] Show extension promotion with updated strings when all installed extensions have been disabled

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ce305c3078a
[Menu Redesign] Show extension promotion with updated strings when all installed extensions have been disabled r=android-reviewers,petru

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing lint failures on android.

Backout link: https://hg.mozilla.org/integration/autoland/rev/5a3b841387ff80aa24eeefa8709d83aec4bafff8

Push with failures

Failure log -> fenix/components/menu/compose/ExtensionsSubmenu.kt:45:14: The function ExtensionsSubmenu is too long (76). The maximum length is 75. [LongMethod]

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/874cebe82ef0
[Menu Redesign] Show extension promotion with updated strings when all installed extensions have been disabled r=android-reviewers,petru

Comment 6

[Iorga Gabriel]

I fixed it and land it again .

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/874cebe82ef0

Comment 8

[Vasilica Tamas QA [:vtamas]]

Attachment: DisabledExtensionPromotio.JPEG

This is verified as fixed on Firefox Nightly 133 (2024-10-21) using a Samsung S24 Ultra (Android 14) and Xiaomi 12T (Android 12). The specific extension promotion is successfully displayed in Extensions Submenu when all extensions are disabled.