1916235 - Sidebar custom settings uses mix of system and theme accent colors with Light/Dark themes

Status: RESOLVED WORKSFORME

(Firefox :: Sidebar, defect, P3)

Description

[Kestrel]

Attachment: Inconsistent accent colors with Light/Dark theme

STR:

1. Set sidebar.revamp = true on Ubuntu 24.04.
2. Enable the Light/Dark theme.
3. Open the sidebar custom settings panel.

Expected:
All controls have consistent accent colors.

Actual:
Checkboxes use the theme accent but radio buttons and links use the system accent (orange for Ubuntu).

The System theme is unaffected, using the same accent for all controls.

Comment 1

[Sarah Clements [:sclements]]

Please keep in mind that this feature is still under development, which should be obvious when you flip prefs. It's not helpful to file a lot of small UX bugs as you have since this is feature is still being worked on and we have QA, UX and a11y review it before it is rolled out widely to users.

Comment 2

[Kestrel]

The radio buttons now use the theme accent with Light/Dark themes on latest Nightly.

Fix window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4ecbd17b778cc602064d474df415637d743f4ba0&tochange=021941b68368227dab5d1a3089652bbb57a11740

Fixed by Bug 1911856.

The link at the bottom is still using the system accent.

Comment 3

[Kestrel]

Attachment: Radio buttons using theme accent leaving only link using system accent

Comment 4

[Kestrel]

The link text color is now using the theme accent.

Fix window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cfcdd5339805363c495841abc4b4f82cd287f712&tochange=39715622ba64b273dbfa4b78d40e4e9872c440ac

Fixed by Bug 1918371.