1918371 - sidebar panels shouldn't unconditionally use system colors.

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

On the system theme on Windows (or on macOS without the native theme), sidebar panels use -moz-sidebar/-moz-sidebartext, rather than the browser-custom-clolors.css overrides...

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1918371 - Use browser-custom-colors.css background if appropriate. r=#theme,#sidebar-reviewers

Remove the sidebar-border variable because it's unused (and it's not one
of the properties that get plumbed down anyways).

Rely on browser.xhtml's background to avoid having to plumb down the
system theme colors. Alternatively we could try to plumb these down, or
add a media query like:

@media not ((prefers-contrast) or (-moz-platform: linux) or ((-moz-platform: macos) and (-moz-bool-pref: "browser.theme.macos.native-theme"))) {
  /* Duplicate browser-custom-colors.css */
}

But that's kind of unwieldy, to the point that we should move
browser-custom-colors.css import to browser-shared and use the same if
we do it, probably, so it's easy to keep them in sync...

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1918371 - Centralize browser colors, and import them from sidebar panels. r=#theme

Not sure if this is better but this solves the issue of having to
duplicate the custom colors stuff to keep them in sync... Thoughts?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd7ccc8b9088
Use browser-custom-colors.css background if appropriate. r=desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/39715622ba64
Centralize browser colors, and import them from sidebar panels. r=desktop-theme-reviewers,sidebar-reviewers,tabbrowser-reviewers,nsharpley,dao

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fd7ccc8b9088
https://hg.mozilla.org/mozilla-central/rev/39715622ba64