1916260 - Allow [[ReferencedName]] in Reference Records to be a not-yet-resolved property key

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[André Bargull [:anba]]

Implement the changes from https://github.com/tc39/ecma262/pull/3307.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1916260 - Part 1: Stop calling ToPropertyKey when deleting super-references. r=#spidermonkey-reviewers!

The spec PR reordered when ToPropertyKey is evaluated. For the delete super
case the ToPropertKey evaluation doesn't happen anymore at all. See [1], step 4.

[1] https://tc39.es/ecma262/#sec-delete-operator-runtime-semantics-evaluation

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1916260 - Part 2: Merge emitElemObjAndKey and emitObjAndKey. r=#spidermonkey-reviewers!

emitObjAndKey is only called from emitElemObjAndKey. Let's merge both methods.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1916260 - Part 3: Remove duplicate code in emitElemObjAndKey. r=#spidermonkey-reviewers!

Reduce code duplicate in emitElemObjAndKey. Also aligns with similar code
elsewhere in BytecodeEmitter, search for callers to emitGetThisForSuperBase.

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1916260 - Part 4: Call emitElemObjAndKey in emitDeleteElement. r=#spidermonkey-reviewers!

emitElemObjAndKey performs the exact same sequence of steps, so there's no
reason not to call it here.

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1916260 - Part 5: Call prepareForObj when deleting super-property references. r=#spidermonkey-reviewers!

prepareForObj only updates PropOpEmitter::state_, so there's no good reason
to omit calling it for the super case.

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1916260 - Part 6: Evaluate SuperBase before ToPropertyKey. r=#spidermonkey-reviewers!

The spec PR reordered the ToPropertyKey call to happen in GetValue resp.
PutValue, which means it has to happen after GetSuperBase.

Tests are included in https://github.com/tc39/test262/pull/4216.

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1916260 - Part 7: Remove test exclusions for deleted tests. r=#spidermonkey-reviewers!

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1916260 - Part 8: Evaluate ComputedPropertyName first. r=#spidermonkey-reviewers!

Computed property names are evaluated first in destructuring contexts.

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1916260 - Part 9: Resolve binding in destructuring before retrieving destructured element. r=#spidermonkey-reviewers!

BytecodeEmitter::emitDestructuringLHSRef needs to call NameOpEmitter::prepareForRhs
to emit the necessary steps to resolve environment bindings. To avoid adding a new
skipPrepareForRhs method to NameOpEmitter, instead pass DestructuringLHSRef&
to emitDestructuringLHSRef, where DestructuringLHSRef holds the emitter for the
destructuring left-hand side reference.

There's always only exactly one emitter instantiated, so using mozilla::MaybeOneOf
seems preferable, except that mozilla::MaybeOneOf only allows two possible states.
Add the new class MaybeOneOfMany to use composition to allow having more than two
states.

Tests are in https://github.com/tc39/test262/pull/4216.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/292abbffea7e
Part 1: Stop calling ToPropertyKey when deleting super-references. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/d6d90dea20a9
Part 2: Merge emitElemObjAndKey and emitObjAndKey. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/d3da96a0aafc
Part 3: Remove duplicate code in emitElemObjAndKey. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/6de1d42ebded
Part 4: Call emitElemObjAndKey in emitDeleteElement. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/e85c796e7639
Part 5: Call prepareForObj when deleting super-property references. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/c4fbbb9b19cc
Part 6: Evaluate SuperBase before ToPropertyKey. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/8fb9d79cf4a2
Part 7: Remove test exclusions for deleted tests. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/023672c91d48
Part 8: Evaluate ComputedPropertyName first. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/5a9e48dab16e
Part 9: Resolve binding in destructuring before retrieving destructured element. r=arai

Comment 12

[Noemi Erli[:noemi_erli]]

Backed out 9 changesets (Bug 1916260) for causing bustage in ElemOpEmitter.h CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=DEXdNdKRTKG8UUGt9px6og.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5a9e48dab16e9706ff963d6155df153acb6a0354

Log: https://treeherder.mozilla.org/logviewer?job_id=472899530&repo=autoland&lineNumber=15053

Backout: https://hg.mozilla.org/integration/autoland/rev/890755664a3edd21d67b0999a534730f0121c933

Comment 13

[André Bargull [:anba]]

Thanks, looks like it's just missing an #include. I'll take a look.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d20c97df0b86
Part 1: Stop calling ToPropertyKey when deleting super-references. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/6c64397920b4
Part 2: Merge emitElemObjAndKey and emitObjAndKey. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/73ef1798d76b
Part 3: Remove duplicate code in emitElemObjAndKey. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/d98e8d9afe8e
Part 4: Call emitElemObjAndKey in emitDeleteElement. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/edc63c19288f
Part 5: Call prepareForObj when deleting super-property references. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/e7e456e896ff
Part 6: Evaluate SuperBase before ToPropertyKey. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/99ff134cb9e0
Part 7: Remove test exclusions for deleted tests. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/50af3f905683
Part 8: Evaluate ComputedPropertyName first. r=spidermonkey-reviewers,jandem
https://hg.mozilla.org/integration/autoland/rev/4c26da6ff326
Part 9: Resolve binding in destructuring before retrieving destructured element. r=arai

Comment 15

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/d20c97df0b86
https://hg.mozilla.org/mozilla-central/rev/6c64397920b4
https://hg.mozilla.org/mozilla-central/rev/73ef1798d76b
https://hg.mozilla.org/mozilla-central/rev/d98e8d9afe8e
https://hg.mozilla.org/mozilla-central/rev/edc63c19288f
https://hg.mozilla.org/mozilla-central/rev/e7e456e896ff
https://hg.mozilla.org/mozilla-central/rev/99ff134cb9e0
https://hg.mozilla.org/mozilla-central/rev/50af3f905683
https://hg.mozilla.org/mozilla-central/rev/4c26da6ff326