1917214 - Perma test262/annexB/language/eval-code/direct/script-decl-lex-no-collision.js | (args: "") [0.0 s] when Gecko 132 merges to beta on 2024-09-30

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Cristina Horotan [:chorotan]]

[Tracking Requested - why for this release]:

• Central-as-beta-simulation
• How to run these simulations
• Failure log

[task 2024-09-06T11:13:39.236Z] TEST-PASS | test262/annexB/language/eval-code/direct/global-block-decl-eval-global-existing-fn-update.js | (args: "") [0.0 s]
[task 2024-09-06T11:13:39.236Z] ## test262/annexB/language/eval-code/direct/script-decl-lex-no-collision.js: rc = 3, run time = 0.035771
[task 2024-09-06T11:13:39.236Z] @evaluate:1:1 SyntaxError: redeclaration of var test262Fn
[task 2024-09-06T11:13:39.237Z] Stack:
[task 2024-09-06T11:13:39.237Z]   @@evaluate:1:1
[task 2024-09-06T11:13:39.237Z]   evaluateScript@/builds/worker/checkouts/gecko/js/src/tests/shell.js:246:15
[task 2024-09-06T11:13:39.237Z]   @/builds/worker/checkouts/gecko/js/src/tests/test262/annexB/language/eval-code/direct/script-decl-lex-no-collision.js:31:6
[task 2024-09-06T11:13:39.237Z] TEST-UNEXPECTED-FAIL | test262/annexB/language/eval-code/direct/script-decl-lex-no-collision.js | (args: "") [0.0 s]
[task 2024-09-06T11:13:39.239Z] TEST-PASS | test262/annexB/language/eval-code/direct/func-if-decl-else-stmt-eval-func-existing-fn-no-init.js | (args: "") [0.0 s]

Comment 1

[André Bargull [:anba]]

This is a regression from bug 1899303.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1899303

Comment 3

[tannal2409]

Is the NIGHTLY_BUILD macro not defined in the beta build?

Comment 4

[André Bargull [:anba]]

https://phabricator.services.mozilla.com/D220704 removed two skip entries, which leads to always executing these tests, even in Beta builds. Instead of deleting the skip entries, they need to be changed to skip-if(release_or_beta), so we only execute the tests on Nightly builds:

# https://github.com/tc39/proposal-redeclarable-global-eval-vars
skip-if(release_or_beta) script test262/language/global-code/script-decl-lex-var-declared-via-eval.js
skip-if(release_or_beta) script test262/annexB/language/eval-code/direct/script-decl-lex-no-collision.js

Comment 5

[tannal2409]

Attachment: Bug 1917214 - Skip tests for redeclarable eval vars proposal in beta and release build. r?dminor

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff89d42684ed
Skip tests for redeclarable eval vars proposal in beta and release build. r=dminor

Comment 7

[Noemi Erli[:noemi_erli]]

The patch is working on today's beta simulation push.

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ff89d42684ed

Comment 9

[Sandor Molnar[:smolnar]]

Verified fixed in latest beta-simulation