Closed Bug 1917214 Opened 3 months ago Closed 3 months ago

Perma test262/annexB/language/eval-code/direct/script-decl-lex-no-collision.js | (args: "") [0.0 s] when Gecko 132 merges to beta on 2024-09-30

Categories

(Core :: JavaScript Engine, defect)

defect

Tracking

()

VERIFIED FIXED
132 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox130 --- unaffected
firefox131 --- unaffected
firefox132 + verified

People

(Reporter: chorotan, Assigned: tannal2409)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

[Tracking Requested - why for this release]:

[task 2024-09-06T11:13:39.236Z] TEST-PASS | test262/annexB/language/eval-code/direct/global-block-decl-eval-global-existing-fn-update.js | (args: "") [0.0 s]
[task 2024-09-06T11:13:39.236Z] ## test262/annexB/language/eval-code/direct/script-decl-lex-no-collision.js: rc = 3, run time = 0.035771
[task 2024-09-06T11:13:39.236Z] @evaluate:1:1 SyntaxError: redeclaration of var test262Fn
[task 2024-09-06T11:13:39.237Z] Stack:
[task 2024-09-06T11:13:39.237Z]   @@evaluate:1:1
[task 2024-09-06T11:13:39.237Z]   evaluateScript@/builds/worker/checkouts/gecko/js/src/tests/shell.js:246:15
[task 2024-09-06T11:13:39.237Z]   @/builds/worker/checkouts/gecko/js/src/tests/test262/annexB/language/eval-code/direct/script-decl-lex-no-collision.js:31:6
[task 2024-09-06T11:13:39.237Z] TEST-UNEXPECTED-FAIL | test262/annexB/language/eval-code/direct/script-decl-lex-no-collision.js | (args: "") [0.0 s]
[task 2024-09-06T11:13:39.239Z] TEST-PASS | test262/annexB/language/eval-code/direct/func-if-decl-else-stmt-eval-func-existing-fn-no-init.js | (args: "") [0.0 s]
Flags: needinfo?(andrebargull)

This is a regression from bug 1899303.

Regressed by: 1899303
No longer regressed by: 1916260

Set release status flags based on info from the regressing bug 1899303

Assignee: nobody → dminor
Flags: needinfo?(andrebargull)

Is the NIGHTLY_BUILD macro not defined in the beta build?

https://phabricator.services.mozilla.com/D220704 removed two skip entries, which leads to always executing these tests, even in Beta builds. Instead of deleting the skip entries, they need to be changed to skip-if(release_or_beta), so we only execute the tests on Nightly builds:

# https://github.com/tc39/proposal-redeclarable-global-eval-vars
skip-if(release_or_beta) script test262/language/global-code/script-decl-lex-var-declared-via-eval.js
skip-if(release_or_beta) script test262/annexB/language/eval-code/direct/script-decl-lex-no-collision.js
Assignee: dminor → andrebargull
Assignee: andrebargull → tannal2409
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff89d42684ed Skip tests for redeclarable eval vars proposal in beta and release build. r=dminor

The patch is working on today's beta simulation push.

Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch

Verified fixed in latest beta-simulation

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: