1916350 - Style of Pressed/active buttons in toolbox toolbar isnt' distinct from regular style in High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Rules highlighter button is active here

In the attached screenshot, the rules highlighter button is active/pressed, but it's not much different from the tracer button that is on its right

Comment 1

[Morgan Reschenberg [:morgan]]

Triaging as S2 because UI doesn't adapt to HCM

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:Honza, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Higher a11y severity is correct in this case.

Comment 4

[Anna Yeddi [:ayeddi]]

Adding a keyword no-plan-to-ship as an ad-hoc flag here. This keyword was meant to exclude specific bugs from the general access-S2 tracking when there are no plans to ship the affected feature. However, we do plan to address and ship this and other HCM-related devtools bugs, which are part of a larger project. This Dev Tools High Contrast Mode support project, tracked by the meta bug 1590215, is ongoing and is tracked by the Dev Tools team separately.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916350 - [devtools] Adapt toolbox toolbar buttons to High Contrast Mode. r=#devtools.

Depends on D228151

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916350 - [devtools] Don't add checked class on experimental toolbar icon to indicate some prefs are enabled. r=#devtools.

This doesn't look great in High Contrast Mode.
Add the small callout icon instead.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d245a1a16c4
[devtools] Adapt toolbox toolbar buttons to High Contrast Mode. r=devtools-reviewers,bomsy.
https://hg.mozilla.org/integration/autoland/rev/ec53c61b42e6
[devtools] Don't add checked class on experimental toolbar icon to indicate some prefs are enabled. r=devtools-reviewers,ochameau.

Comment 8

[amarc]

Backed out for causing multiple dt failures complaining about undefined inspector

• Backout link
• Push with failures
• Failure Log
• Failure lines:

TEST-UNEXPECTED-FAIL | devtools/client/inspector/flexbox/test/browser_flexbox_accordion_state.js | Uncaught exception in test bound  - at chrome://mochitests/content/browser/devtools/client/inspector/test/shared-head.js:60 - TypeError: can't access property "sidebar", inspector is undefined

TEST-UNEXPECTED-FAIL | devtools/client/dom/test/browser_dom_array.js | Uncaught exception in test bound  - at chrome://mochitests/content/browser/devtools/client/dom/test/head.js:46 - TypeError: can't access property "panelWin", panel is undefined

TEST-UNEXPECTED-FAIL | devtools/client/inspector/extensions/test/browser_inspector_extension_sidebar.js | Uncaught exception in test bound setupExtensionSidebar - at chrome://mochitests/content/browser/devtools/client/inspector/extensions/test/browser_inspector_extension_sidebar.js:49 - TypeError: can't access property "getPanel", inspector is undefined

TEST-UNEXPECTED-FAIL | devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_evaluation_context.js | Uncaught exception in test bound  - at chrome://mochitests/content/browser/devtools/client/framework/browser-toolbox/test/helpers-browser-toolbox.js:165 - Error: ToolboxTask.spawn await rejected

Comment 9

[Phabricator Automation]

Comment on attachment 9437641 [details]
Bug 1916350 - [devtools] Don't add checked class on experimental toolbar icon to indicate some prefs are enabled. r=#devtools.

Revision D228944 was moved to bug 1933315. Setting attachment 9437641 [details] to obsolete.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b60142a5a1aa
[devtools] Adapt toolbox toolbar buttons to High Contrast Mode. r=devtools-reviewers,bomsy.

Comment 11

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/b60142a5a1aa