1933315 - Don't add checked class on experimental toolbar icon to indicate some prefs are enabled

Status: ASSIGNED

(DevTools :: Framework, task, P3)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1933315 - [devtools] Don't add checked class on experimental toolbar icon to indicate some prefs are enabled. r=#devtools.

This doesn't look great in High Contrast Mode.
Add the small callout icon instead.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:nchevobbe, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Can't remember what was missing, I'll check again

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ac8202ae1c3
[devtools] Don't add checked class on experimental toolbar icon to indicate some prefs are enabled. r=devtools-reviewers,ochameau.

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing multiple failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | devtools/client/framework/browser-toolbox/test/browser_browser_toolbox_evaluation_context.js | Uncaught exception in test bound - at chrome://mochitests/content/browser/devtools/client/framework/browser-toolbox/test/helpers-browser-toolbox.js:165 - Error: ToolboxTask.spawn await rejected

Please also check these mochitests failures and these devtools failures.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)

Can't remember what was missing, I'll check again

okay that's because tests are failing:

[task 2025-04-01T06:47:03.348Z] 06:47:03     INFO - GECKO(1003) | console.error: "Exception while opening the toolbox" "Error: Module `resource://devtools/client/devtools-experimental-prefs.js` is not found at resource://devtools/client/devtools-experimental-prefs.js" (new Error("Module `resource://devtools/client/devtools-experimental-prefs.js` is not found at resource://devtools/client/devtools-experimental-prefs.js", "resource://devtools/shared/loader/base-loader.sys.mjs", 210))