1916424 - Support idle tasks in category manager JS invocations, to start using it from BrowserGlue

Status: RESOLVED FIXED

(Firefox :: General, task, P3)

Description

[:Gijs (he/him)]

All the .init and uninit calls in BrowserGlue are a little sad, and could easily be switched to use the category manager, so let's try and make that happen.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::JavaScript Engine' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1916424 - allow idle dispatch from BrowserUtils' category manager-based invocations, r?Mossop

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1916424 - use category manager for idle startup tasks from BrowserGlue, r?#firefox-desktop-core-reviewers

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1916424 - use category manager for quit-application-granted consumers from BrowserGlue, r?#firefox-desktop-core-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad04587bad59
allow idle dispatch from BrowserUtils' category manager-based invocations, r=mossop,search-reviewers,urlbar-reviewers

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ad04587bad59

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4b2ef6e086b
use category manager for idle startup tasks from BrowserGlue, r=firefox-desktop-core-reviewers ,mossop
https://hg.mozilla.org/integration/autoland/rev/8e0862096be2
use category manager for quit-application-granted consumers from BrowserGlue, r=firefox-desktop-core-reviewers ,mossop

Comment 8

[amarc]

Backed out for causing leaks @ Alloc, JSString::OwnedChars

• Backout link
• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-FAIL | LeakSanitizer leak at Alloc, JSString::OwnedChars, js::NewAtomCopyNDontDeflateValidLength, NewAtomNonStaticValidLength | browser/components/search/test/browser/telemetry/browser.toml

Comment 9

[:Gijs (he/him)]

https://treeherder.mozilla.org/jobs?repo=try&revision=5715aad50453148d2df981042431dc5de5ec0887

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44085a6af3dd
use category manager for idle startup tasks from BrowserGlue, r=firefox-desktop-core-reviewers ,mossop
https://hg.mozilla.org/integration/autoland/rev/47360b5eb434
use category manager for quit-application-granted consumers from BrowserGlue, r=firefox-desktop-core-reviewers ,mossop

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/44085a6af3dd
https://hg.mozilla.org/mozilla-central/rev/47360b5eb434