1916479 - History sidebar background color no longer fills the full height

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Kestrel]

Attachment: Sidebar background color stops, constrained by sidebar-panel height

STR:

1. Start with sidebar.revamp = true.
2. Open the History sidebar (Ctrl+H).
3. Create enough history for the list to be scrollable.
4. Scroll down.

Expected:
Background color remains the same in the sidebar.

Actual:
After one page, the background color changes.

Easier to see with the Dark theme but it also happens with Light and System themes.

The sidebar-panel does not fill the full scroll height but this was not previously visible since #sidebar-box used the same --sidebar-background-color. Now it has changed to --toolbar-bgcolor there is a visible mismatch.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=936f3047272d1ef5feb4f02953db3ad74c59bbd1&tochange=95109305b579922c59ef5966e60c9397e48847ac

Regressed by Bug 1910733.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1910733

:nsharpley, since you are the author of the regressor, bug 1910733, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Sarah Clements [:sclements]]

Its annoying the bugbot is triggered for this considering its only in Nightly right now. We'll get to a fix for this after we prioritize other things.

Comment 3

[Kestrel]

Fix window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ef10408825c67a085dd242c238ddcc94b3224750&tochange=8f9c8d7aeb4ab75a27564d16bc1671da947dd7d0

Fixed by Bug 1917557.