1917557 - Bug 1886847 should've tweaked browser-custom-colors.css too.

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect)

Comment 1

[Sarah Clements [:sclements]]

Can you add a description? Its not clear what specifically we should have adjusted in that file?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1917557 - Update browser-custom-colors.css to override sidebar system theme. r=#sidebar-reviewers,#theme

Seems bug 1886847 missed this. Ideally light/dark themes will remain in
sync with browser-custom-colors.css more automatically, to avoid
introducing windows system theme differences from our default themes.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1917557 - Make sidebar box and background more consistent between windows system theme and non-system themes. r=#sidebar-reviewers,#theme

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1917557 - Remove unneeded sidebar styles. r=#sidebar-reviewers,#theme

These shouldn't have any effect in rendering:

• We are full-height because we're in a vertical flexbox with flex:1.
• We are full-width because that's the default flexbox behavior.

So let's minimize unneeded styling differences with and without sidevar.revamp.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

See above. I found this while looking at bug 1916762 which you asked me to look into. I'll elaborate there :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11b7870db8e2
Update browser-custom-colors.css to override sidebar system theme. r=sidebar-reviewers,desktop-theme-reviewers,dao,sclements
https://hg.mozilla.org/integration/autoland/rev/64f6ec287a58
Make sidebar box and background more consistent between windows system theme and non-system themes. r=sidebar-reviewers,desktop-theme-reviewers,dao,sclements
https://hg.mozilla.org/integration/autoland/rev/8f9c8d7aeb4a
Remove unneeded sidebar styles. r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/11b7870db8e2
https://hg.mozilla.org/mozilla-central/rev/64f6ec287a58
https://hg.mozilla.org/mozilla-central/rev/8f9c8d7aeb4a