1916666 - Rules view filter input "no match" style don't adapt to High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: rules view filter input

See screenshot (I tweaked the base variable colors so it's easier to spot)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Triaging as S2 because UI doesn't adapt to HCM

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:jdescottes, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[Julian Descottes [:jdescottes]]

For those bugs it's fine to have a different severity than the accessibility severity

Comment 4

[Anna Yeddi [:ayeddi]]

Adding a keyword no-plan-to-ship as an ad-hoc flag here. This keyword was meant to exclude specific bugs from the general access-S2 tracking when there are no plans to ship the affected feature. However, we do plan to address and ship this and other HCM-related devtools bugs, which are part of a larger project. This Dev Tools High Contrast Mode support project, tracked by the meta bug 1590215, is ongoing and is tracked by the Dev Tools team separately.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Bug 1916333 fixed most of the issue, now we only need to take care of the "no match" style where we make the icon red

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: HCM proposed design for error inp

I'm not sure we can use something like this

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1916666 - [devtools] Don't set separate color for Rules view filter input when there is no match in HCM. r=#devtools.

The HCM guidelines indicate we shouldn't have different colors on the input.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81c38b6c809a
[devtools] Don't set separate color for Rules view filter input when there is no match in HCM. r=devtools-reviewers,ochameau.

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/81c38b6c809a