Closed Bug 1916710 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 47961 - Add meta charset tag to canvas generator templates

Categories

(Core :: Graphics: Canvas2D, task, P4)

task

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 47961 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47961
Details from upstream follow.

Andres Ricardo Perez <andresrperez@chromium.org> wrote:

Add meta charset tag to canvas generator templates

In order to fully test canvas text-related features, it is necessary to
use different alphabets and special characters for coverage. Before this
change, several special characters, for example the arabic alphabet and
emojis, weren't actually supported when run from the WPT testing toolkit.

This CL adds the `\<meta charset="UTF-8">' line to all generator
templates, and includes the results of running the generator. All
generated files are modified, but only by adding this line.

One test that uses special characters failed after updating the
encoding (2d.text.measure.caret-position.tentative). This was added to
the test expectations. See: https://crbug.com/364332944

Bug: 341213359, 364332944
Change-Id: I7acf60298ac49b790d58100044c2e6412011093d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5817356
Reviewed-by: Yi Xu \<yiyix@chromium.org>
Reviewed-by: Jean-Philippe Gravel \<jpgravel@chromium.org>
Commit-Queue: Andres Ricardo Perez \<andresrperez@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1350746}

Component: web-platform-tests → Graphics: Canvas2D
Product: Testing → Core
Attached file Notable wpt changes
# CI Results Ran 6 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 1785 tests ## Status Summary ### Firefox `OK` : 496[Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 500[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 1561[GitHub] `PASS` : 456[Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 462[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 1510[GitHub] `FAIL` : 43[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 45[Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 383[GitHub] `TIMEOUT`: 60 ### Chrome `OK` : 1560 `PASS` : 1872 `FAIL` : 80 `ERROR` : 1 ### Safari `OK` : 1560 `PASS` : 1469 `CRASH` : 2 `FAIL` : 422 `TIMEOUT`: 61 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=02e34337848be0d2885507ace35f81b19a6d30d7) [GitHub PR Head](https://wpt.fyi/results/?sha=5c45f5478da721bd2ff15496d223068ab8e5b34c&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=5c45f5478da721bd2ff15496d223068ab8e5b34c&label=pr_base) ## Details ### Firefox-only Failures * [/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.reload.html](https://wpt.live/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.reload.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.reload.html)] * Canvas test: 2d.drawImage.incomplete.reload: `FAIL` linked bug:Bug 1646754 * [/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.colormix.currentcolor.html](https://wpt.live/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.colormix.currentcolor.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.colormix.currentcolor.html)] * color-mix works as color input with currentcolor: `FAIL` * [/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.colormix.html](https://wpt.live/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.colormix.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.colormix.html)] * color-mix works as color input: `FAIL` * [/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.incomplete.reload.html](https://wpt.live/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.incomplete.reload.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.incomplete.reload.html)] * Canvas test: 2d.pattern.image.incomplete.reload: `FAIL` linked bug:Bug 1646754 * [/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.colormix.html](https://wpt.live/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.colormix.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.colormix.html)] * color-mix works as color input: `FAIL` * [/html/canvas/element/reset/2d.reset.state.image_smoothing_quality.html](https://wpt.live/html/canvas/element/reset/2d.reset.state.image_smoothing_quality.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/element/reset/2d.reset.state.image_smoothing_quality.html)] * check that the state is reset: `FAIL` * [/html/canvas/element/text/2d.text.font.parse.system.html](https://wpt.live/html/canvas/element/text/2d.text.font.parse.system.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/element/text/2d.text.font.parse.system.html)] * System fonts must be computed to explicit values: `FAIL` linked bug:Bug 1646754 * [/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.fillText.html](https://wpt.live/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.fillText.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.fillText.html)] * Test if fillText can be used with a solid display-p3 color: `FAIL` * [/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.fillText.shadow.html](https://wpt.live/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.fillText.shadow.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.fillText.shadow.html)] * Test if fillText can be used with a display-p3 shadow color: `FAIL` * [/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.strokeText.html](https://wpt.live/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.strokeText.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.strokeText.html)] * Test if strokeText can be used with a solid display-p3 color: `FAIL` * [/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.to.p3.html](https://wpt.live/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.to.p3.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.to.p3.html)] * test getImageData with display-p3 and uint8 from display p3 uint8 canvas: `FAIL` linked bug:Bug 1704237 * [/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.colormix.html](https://wpt.live/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.colormix.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.colormix.html)] * color-mix works as color input: `FAIL` * [/html/canvas/offscreen/fill-and-stroke-styles/2d.strokeStyle.colormix.html](https://wpt.live/html/canvas/offscreen/fill-and-stroke-styles/2d.strokeStyle.colormix.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/offscreen/fill-and-stroke-styles/2d.strokeStyle.colormix.html)] * color-mix works as color input: `FAIL` * [/html/canvas/offscreen/reset/2d.reset.state.image_smoothing_quality.html](https://wpt.live/html/canvas/offscreen/reset/2d.reset.state.image_smoothing_quality.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/offscreen/reset/2d.reset.state.image_smoothing_quality.html)] * check that the state is reset: `FAIL` * [/html/canvas/offscreen/wide-gamut-canvas/2d.color.space.p3.to.p3.html](https://wpt.live/html/canvas/offscreen/wide-gamut-canvas/2d.color.space.p3.to.p3.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/offscreen/wide-gamut-canvas/2d.color.space.p3.to.p3.html)] * test getImageData with display-p3 and uint8 from display p3 uint8 canvas: `FAIL` linked bug:Bug 1704237 * [/html/canvas/offscreen/reset/2d.reset.render.line.html](https://wpt.live/html/canvas/offscreen/reset/2d.reset.render.line.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/offscreen/reset/2d.reset.render.line.html)]: `FAIL` * [/html/canvas/offscreen/reset/2d.reset.render.line.w.html](https://wpt.live/html/canvas/offscreen/reset/2d.reset.render.line.w.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/offscreen/reset/2d.reset.render.line.w.html)]: `FAIL` * [/html/canvas/offscreen/reset/2d.reset.render.misc.html](https://wpt.live/html/canvas/offscreen/reset/2d.reset.render.misc.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/offscreen/reset/2d.reset.render.misc.html)]: `FAIL` * [/html/canvas/offscreen/reset/2d.reset.render.misc.w.html](https://wpt.live/html/canvas/offscreen/reset/2d.reset.render.misc.w.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/offscreen/reset/2d.reset.render.misc.w.html)]: `FAIL` * [/html/canvas/offscreen/reset/2d.reset.render.miter_limit.html](https://wpt.live/html/canvas/offscreen/reset/2d.reset.render.miter_limit.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/offscreen/reset/2d.reset.render.miter_limit.html)]: `FAIL` * [/html/canvas/offscreen/reset/2d.reset.render.miter_limit.w.html](https://wpt.live/html/canvas/offscreen/reset/2d.reset.render.miter_limit.w.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/offscreen/reset/2d.reset.render.miter_limit.w.html)]: `FAIL` * [/html/canvas/offscreen/text/2d.text.fontVariantCaps.after.reset.font.html](https://wpt.live/html/canvas/offscreen/text/2d.text.fontVariantCaps.after.reset.font.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/offscreen/text/2d.text.fontVariantCaps.after.reset.font.html)]: `FAIL` * [/html/canvas/offscreen/text/2d.text.fontVariantCaps.after.reset.font.w.html](https://wpt.live/html/canvas/offscreen/text/2d.text.fontVariantCaps.after.reset.font.w.html) [[wpt.fyi](https://wpt.fyi/results/html/canvas/offscreen/text/2d.text.fontVariantCaps.after.reset.font.w.html)]: `FAIL` (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1996e4a49739 [wpt PR 47961] - Add meta charset tag to canvas generator templates, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: