Closed
Bug 1916820
Opened 1 year ago
Closed 1 year ago
Replace --in-content-accent-color-active with the --color-accent-primary-active token
Categories
(Toolkit :: Themes, task)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
134 Branch
| Tracking | Status | |
|---|---|---|
| firefox134 | --- | fixed |
People
(Reporter: hjones, Assigned: mkennedy, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp][lang=css])
Attachments
(1 file)
|
Bug 1916820 - Replace in-content-accent-color-active with color-accent-primary-active token r?hjones
48 bytes,
text/x-phabricator-request
|
Details | Review |
The --in-content-accent-color-active variable serves the same purpose as --color-accent-primary-active so we should replace the former with the latter. The values for --color-accent-primary-active are slightly different - --in-content-accent-color-active actually uses the same values as --color-accent-primary-hover. For the purposes of semantics/consistency we should use the -active token for replacement.
Updated•1 year ago
|
| Assignee | ||
Updated•1 year ago
|
Assignee: nobody → mkennedy
| Assignee | ||
Comment 1•1 year ago
|
||
Pushed by hjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/792b285e0db3
Replace in-content-accent-color-active with color-accent-primary-active token r=hjones,desktop-theme-reviewers
Comment 3•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox134:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•