1916960 - Integrate SharedSubResourceCache into DevTools network monitor

Status: RESOLVED FIXED

(DevTools :: Netmonitor, task)

Description

[Tooru Fujisawa [:arai]]

Similar to bug 1722759, we have in-process cache for CSS (mozilla::SharedStyleSheetCache), and JS (mozilla::dom::SharedScriptCache, preffed off by default).

When those cache is used, the request doesn't go to necko, and the network request is not recorded in the DevTools Network Monitor.
We should integrate the SharedSubResourceCache's result into Network Monitor, so that the cached case is also shown there, in the same way as image's cache.

bug 1899734 is similar issue for performance API, which I already have a patch stack to fix.
I'll look into this after the bug.

Comment 1

[Tooru Fujisawa [:arai]]

The network monitor code seems to require an nsIHttpChannel, and the image loader is creating a dummy channel with dummy header for the cached case.

If we follow that style, it means the SharedSubResourceCache's cached case (either complete or pending/loading) also need to create a dummy channel (for the first load in the document).
I wonder if there can be some performance impact, or there can be some other concern.

emilio, can I have your opinion?
Do you see any possible issue?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

:shasha is looking at this in bug 1884876... I think creating a cache is ok as long as we do it only conditional on DevTools being open (which is the HasObservers call she has there).

Comment 3

[Tooru Fujisawa [:arai]]

Thanks!
Indeed it's the same issue. I'll close this bug and look into the patch there.

Comment 4

[Tooru Fujisawa [:arai]]

Actually, there are some more work necessary to make all cases (loading/pending caches, and non-<link> cases) handled for sub resource cache.

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 1: Add helper function to create a channel for stylesheet. r?emilio!

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 2: Move the use-counter and loads-performed handling out of CreateSheet. r?emilio!

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 3: Trigger notification of the cached load in all caces. r?emilio!

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 4: Trigger notification of the cached load in incomplete-cache caces. r?emilio!

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 5: Use the correct CORSMode value for notification. r?emilio!

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 6: Trigger notification for all channels. r?emilio!

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 7: Add TODO for filling more fields in the notification. r?emilio!

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 8: Handle http-on-stylesheet-cache-response in DevTools network monitor. r?jdescottes!

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 9: Add tests for CSS cache in DevTools. r?jdescottes!

Comment 14

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 10: Trigger notification for the cached script load. r?bthrall!

Comment 15

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 11: Handle http-on-resource-cache-response in DevTools network monitor. r?jdescottes!

Comment 16

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 12: Add tests for JS cache in DevTools. r?jdescottes!

Comment 17

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 13: Enable web-platform-test for WebDriver BiDi with cached stylesheets. r?jdescottes!

Comment 18

[Tooru Fujisawa [:arai]]

bug 1899734 will add cached-data handling, and we can add more info there for the HTTP headers for DevTools/WebDriver notifications as well, in bug 1915626.

We'll still need to use different conditions for triggering the notification, because the notification with channel is high-cost, while the performance API integration doesn't require the channel and also it needs to be performed unconditionally.

Also bug 1919218 is for unifying the notifications for image/css/js, with fixing the consumers at the same time.

Comment 19

[Tooru Fujisawa [:arai]]

Attachment: Bug 1916960 - Part 14: Disable WebDriver testcase that expects multiple notifications within single document. r?jdescottes!

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/248f51d7b630
Part 1: Add helper function to create a channel for stylesheet. r=emilio
https://hg.mozilla.org/integration/autoland/rev/2a7c72f1d4a2
Part 2: Move the use-counter and loads-performed handling out of CreateSheet. r=emilio
https://hg.mozilla.org/integration/autoland/rev/9665162d9882
Part 3: Trigger notification of the cached load in all caces. r=emilio
https://hg.mozilla.org/integration/autoland/rev/87e5eee230b9
Part 5: Use the correct CORSMode value for notification. r=emilio
https://hg.mozilla.org/integration/autoland/rev/77456d1f70d0
Part 6: Trigger notification for all channels. r=emilio
https://hg.mozilla.org/integration/autoland/rev/98a32fe3d03f
Part 7: Add TODO for filling more fields in the notification. r=emilio
https://hg.mozilla.org/integration/autoland/rev/e327d3a05d80
Part 8: Handle http-on-stylesheet-cache-response in DevTools network monitor. r=jdescottes,devtools-reviewers
https://hg.mozilla.org/integration/autoland/rev/a1e031eb440d
Part 9: Add tests for CSS cache in DevTools. r=jdescottes,devtools-reviewers
https://hg.mozilla.org/integration/autoland/rev/4e0d1427f4af
Part 10: Trigger notification for the cached script load. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/71f9b6e37759
Part 11: Handle http-on-resource-cache-response in DevTools network monitor. r=jdescottes,devtools-reviewers
https://hg.mozilla.org/integration/autoland/rev/1f30191c85d8
Part 12: Add tests for JS cache in DevTools. r=jdescottes,devtools-reviewers
https://hg.mozilla.org/integration/autoland/rev/331d2711a95b
Part 13: Enable web-platform-test for WebDriver BiDi with cached stylesheets. r=jdescottes,webdriver-reviewers,whimboo

Comment 21

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/248f51d7b630
https://hg.mozilla.org/mozilla-central/rev/2a7c72f1d4a2
https://hg.mozilla.org/mozilla-central/rev/9665162d9882
https://hg.mozilla.org/mozilla-central/rev/87e5eee230b9
https://hg.mozilla.org/mozilla-central/rev/77456d1f70d0
https://hg.mozilla.org/mozilla-central/rev/98a32fe3d03f
https://hg.mozilla.org/mozilla-central/rev/e327d3a05d80
https://hg.mozilla.org/mozilla-central/rev/a1e031eb440d
https://hg.mozilla.org/mozilla-central/rev/4e0d1427f4af
https://hg.mozilla.org/mozilla-central/rev/71f9b6e37759
https://hg.mozilla.org/mozilla-central/rev/1f30191c85d8
https://hg.mozilla.org/mozilla-central/rev/331d2711a95b