Closed Bug 1917040 Opened 1 month ago Closed 1 month ago

Use outline for content separator.

Categories

(Firefox :: Sidebar, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

No description provided.

I did not think of it at the time but outline gives us the right
snapping characteristics for free, so it's simpler.

Type: defect → enhancement
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bad7d0ccd267 Use outline for content separator. r=desktop-theme-reviewers,dao

Backed out for causing mochitests failures in browser_ext_themes_separators.js.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_separators.js | Bottom separator color properly set: none - false == true -
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21a4598702cf Use outline for content separator. r=desktop-theme-reviewers,dao
Blocks: 1917207
Flags: needinfo?(emilio)
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
Duplicate of this bug: 1917207

(In reply to Pulsebot from comment #4)

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/21a4598702cf
Use outline for content separator. r=desktop-theme-reviewers,dao

Perfherder has detected a talos performance change from push 21a4598702cfe48a4c93f8e0a7cfcf1ea530992a.

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
6% tresize linux1804-64-shippable-qr e10s fission stylo webrender-sw 30.09 -> 28.31
4% tresize linux1804-64-shippable-qr e10s fission stylo webrender-sw 30.00 -> 28.67

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 2075

For more information on performance sheriffing please see our FAQ.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: