1916004 - Transparent seams with revamped sidebar with default Linux theme

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Screenshot

See the orange bits which are part of the wallpaper.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Also happens in fullscreen which is slightly more annoying actually :)

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1916004 - Use a box shadow for chrome/content separator. r=dao!

This makes it work in fullscreen and regardless of whether the sidebar
(or the toolbox for that matter) is shown.

Comment 4

[Sarah Clements [:sclements]]

This looks like a duplicate of bug 1916004, for which Nikki also has a patch up for review. I appreciate the patch but please make sure #sidebar-reviewers group are included in any patches like this since we're actively working on bugs very quickly for 132. :)

Edit: Her patch is a draft so if this solves the issue we'll take it.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

(In reply to Sarah Clements [:sclements] from comment #4)

This looks like a duplicate of bug 1916004

Wrong bug #? That's this bug. I did look at whether there were other regressions filed against bug 1910733, and when I filed this bug 1916195 wasn't on file :)

Comment 6

[Sarah Clements [:sclements]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

(In reply to Sarah Clements [:sclements] from comment #4)

This looks like a duplicate of bug 1916004

Wrong bug #? That's this bug. I did look at whether there were other regressions filed against bug 1910733, and when I filed this bug 1916195 wasn't on file :)

Sorry... I meant bug 1915796. Looks like that was filed on the same day so that probably just got easily missed.

Comment 7

[Sarah Clements [:sclements]]

Emilio, does your patch also address bug bug 1916195?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Yeah it also got filed against a different regressor.

Yeah it should fix the extra border of bug 1916195 afaict (though the extra separation is a different thing)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1203aa11e65
Use a box shadow for chrome/content separator. r=dao,desktop-theme-reviewers,tabbrowser-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a23af3c7f5c5
Fix browser_ext_themes_separators.js.

Comment 11

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/a1203aa11e65
https://hg.mozilla.org/mozilla-central/rev/a23af3c7f5c5

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1910733

Comment 15

[Nikki Sharpley (:nikkis) (she/her)]

:emilio, thanks for the quick fix! :)

One thing I noticed though, whilst the border issue is fixed we have lost the intended box-shadow from the designs: https://www.figma.com/design/ZFavpnAJee39j2mFf8U3D0/Sidebar-UX-Spec?node-id=10888-131407&node-type=INSTANCE&t=dC8ZAIncM2a9k0Nk-0
It should have a 0.5px border as well as a subtle box-shadow, for both the sidebar-panel and browser content.

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Can you elaborate? I see the box-shadow here in Nightly (and the code is here). One thing to note is that the border now overlaps the shadow, so maybe we need to make it a tiny bit bigger?

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Ah, I don't see the top with the "bookmarks toolbar overlapping the new tab page". Is that what you meant?

Comment 18

[Kestrel]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #17)

Ah, I don't see the top with the "bookmarks toolbar overlapping the new tab page".

That is Bug 1914938.

Comment 19

[Nikki Sharpley (:nikkis) (she/her)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #16)

Can you elaborate? I see the box-shadow here in Nightly (and the code is here). One thing to note is that the border now overlaps the shadow, so maybe we need to make it a tiny bit bigger?

It looks like the box-shadow is essentially the border currently, which is a nifty fix for this issue. But it does mean no shadow effect, which we want. Its very subtle. Perhaps making it bigger as you suggest?

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d1362860fbe
Address review feedback that I forgot to push to phab.

Comment 21

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4d1362860fbe

Comment 23

[Ryan VanderMeulen [:RyanVM]]

Is this something we should uplift to Beta? Please nominate if so.

Comment 24

[Emilio Cobos Álvarez (:emilio)]

I don't think we're shipping this past nightly right now, right? So I don't think so.

Comment 25

[Dão Gottwald [:dao]]

Correct. 132 is where the sidebar team wants to run the release experiment.

Comment 26

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 131.0a1 (2024-08-30) on Ubuntu 24.04. Sidebar borders are transparent with the System theme.
The issue is verified fixed with Firefox 132.0b5 on Windows 10x64, macOS 12 and Ubuntu 24.04. The borders are not transparent with the System theme.