1917092 - Three-dot menu on BrowserFragment does not show the 'Reconnect to Sync' broken state consistently

Status: NEW

(Fenix :: Accounts and Sync, defect, P2)

Description

[Jonathan Almeida [:jonalmeida]]

Attachment: HomeFragment vs BrowserFragment menu

Pre-requisite

1. Have an account signed in.
2. Go to accounts.firefox.com and remove that device from there. Restart Fenix.

Steps to reproduce

1. Click on the three-dot menu when on the HomeFragment.
2. Observe.
3. Click on the three-dot menu when on the BrowserFragment.
4. Observe.

Expected behaviour

• At 2 and 4, the three-dot menu displays the 'Reconnect to Sync' highlighted menu.

Actual behaviour

• At step 2, the three-dot menu displays the 'Reconnect to Sync' highlighted menu.
• At step 4, the three-dot menu DOES NOT displays the 'Reconnect to Sync' highlighted menu.

Device information

• Firefox version: 131
• Android device model: All devices
• Android OS version: All versions

Any additional information?

Reproducible with and without the double bottom toolbar.

Comment 1

[Jonathan Almeida [:jonalmeida]]

Possibly related to this other bug 1915485.

Comment 2

[Chris Peterson [:cpeterson]]

Jonathan, would this bug also need to be fixed in the new menu design? Or do you expect that one fix would fix both menus?

Comment 3

[Jonathan Almeida [:jonalmeida]]

From a quick look at the code, this would be a bug that is fixed with the new menu. However, if the menu is not shipping soon, I'd recommend fixing this bug sooner than that then.

Comment 4

[Chris Peterson [:cpeterson]]

this would be a bug that is fixed with the new menu. However, if the menu is not shipping soon, I'd recommend fixing this bug sooner than that then.

The new menu can't ship until the new toolbar ships, which is not expected until February 2025. So we should probably fix this bug sooner. I'll bump the priority up to P2, but I don't know who might pick it up. Since this bug is about the Sync state, I'll move from the Toolbar component to Accounts and Sync.