1915485 - Failure to load the account profile leaves "Account info" in the menu instead of any account details

Status: NEW

(Fenix :: Accounts and Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: Note "Account info" where my email or display name should be.

Easiest way to reproduce is to instrument app-services to fail to return a profile, or similarly instrument the code referenced below. What happens is:

In SyncStoreSupport.onAuthenticated, if we fail to obtain the profile we early-abort and never call store.dispatch(SyncAction.UpdateAccount(syncAccount)) etc. However, even in the case of failure to get the profile, we do have some account info available - ie, the email and the uid. But this isn't communicated.

Later, when we try and get a label to use for the menu, we can't get any info about the account, so show the default "Account Info" string.

Once in this state we never seem to recover - ie, it's not clear we ever retry the profile, so the menu remains in this state.

Other UI elements are similarly impacted - eg, the "settings" menu shows generic labels etc too.

This might be the cause of bug 1914044 - in that bug the user is trying to pair - but it's possible the user was connected to Sync, but the menu state made them assume somehow they got disconnected, so tried to repair that. However, nothing I described above would explain that menu item showing if they were not already connected, so I'm not yet treating these as a dupe.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Jeff Boek [:boek]]

Hey Mark, are you able to reproduce this with the latest patch that Jon landed yesterday?

Comment 3

[brixtertabun]

(In reply to Jeff Boek [:boek] from comment #2)

Hey Mark, are you able to reproduce this with the latest patch that Jon landed yesterday?

I still get "Account info" displayed even if I'm logged in. I use the latest Firefox Android version.