Closed Bug 1917102 Opened 2 months ago Closed 2 months ago

Update wgpu to c2e0ad293 (2024-09-12)

Categories

(Core :: Graphics: WebGPU, task, P1)

task

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: jimb, Assigned: jimb)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

What it says on the tin.

Summary: Update wgpu to ec2100052 → Update wgpu to ec2100052 (2024-9-5)
Severity: -- → S3
Type: defect → task
Priority: -- → P1
Assignee: nobody → jimb
Status: NEW → ASSIGNED
See Also: → 1915572
Blocks: 1878320
Severity: S3 → --
Summary: Update wgpu to ec2100052 (2024-9-5) → Update wgpu to ec2100052 (2024-09-05)
Pushed by egubler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0eb0e97434f1 Update serde and serde_derive to 1.0.209. r=supply-chain-reviewers,webgpu-reviewers,nical
Attachment #9423055 - Attachment description: Bug 1917102: Update wgpu crates to ec2100052 (2024-9-5). → Bug 1917102: Update wgpu crates to ec2100052 (2024-09-05). r=#webgpu-reviewers

Implemented with moz-webgpu-cts v1.3.0, using moz-webgpu-cts update-expected --preset reset-contradictory --implementation-status backlog with reports from try:c75bc73e5301.

Attachment #9423304 - Attachment description: WIP: Bug 1917102 - test(webgpu): CTS tier promotions and demotions, `backlog` perma changes r=#webgpu-reviewers → Bug 1917102 - test(webgpu): CTS tier promotions and demotions, `backlog` perma changes r=#webgpu-reviewers
Attachment #9423305 - Attachment description: WIP: Bug 1917102 - test(webgpu): reset contradictory `backlog` results from `try:c75bc73e5301b275d517d7c5ecd47b7ac67e5b37` r=#webgpu-reviewers → Bug 1917102 - test(webgpu): reset contradictory `backlog` results from `try:c75bc73e5301b275d517d7c5ecd47b7ac67e5b37` r=#webgpu-reviewers

Try push with the latest patch stack that includes adjustments to CTS metadata: try:da341fe84de4

Short summary: Looking good! 😀 For example, all regressions in D221366 have been undone.

Pushed by jblandy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2119546af722 Update wgpu crates to ec2100052 (2024-09-05). r=supply-chain-reviewers,webgpu-reviewers,nical,ErichDonGubler
Pushed by jblandy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f77816ce785b test(webgpu): CTS tier promotions and demotions, `backlog` perma changes r=webgpu-reviewers,jimb https://hg.mozilla.org/integration/autoland/rev/1f02a210aaec test(webgpu): reset contradictory `backlog` results from `try:c75bc73e5301b275d517d7c5ecd47b7ac67e5b37` r=webgpu-reviewers,jimb
Flags: needinfo?(jimb)

The crashes in Bug 1917444 are caused by us now using into_device_result on the result of D3D12CreateDevice (https://github.com/gfx-rs/wgpu/commit/dd01b6d20967f1b4a74e9a75baec6b54545ebfec) which panics on unexpected error variants due to the internal_error_panic feature being turned on.

Attachment #9423054 - Attachment description: Bug 1917102: Update serde and serde_derive to 1.0.209. → WIP: Bug 1917102: Update serde and serde_derive to 1.0.210.
Attachment #9423055 - Attachment description: Bug 1917102: Update wgpu crates to ec2100052 (2024-09-05). r=#webgpu-reviewers → Bug 1917102: Update wgpu crates to c2e0ad293 (2024-09-12). r=#webgpu-reviewers
Flags: needinfo?(jimb)
Summary: Update wgpu to ec2100052 (2024-09-05) → Update wgpu to c2e0ad293 (2024-09-12)

That push didn't work out; apparently there are keys that are rotated that are stored both in the CI infra code and in Mozilla Central, so if you do a try push with old sources, you get errors like:

Loading initial page https://web-platform.test:8443/testharness_runner.html failed. Ensure that the there are no other programs bound to this port and that your firewall rules or network setup does not prevent access.

If I'm understanding this comment, the fix is to rebase on something more recent. Hence:

New try push

Okay, that try push looks good.

Attachment #9423054 - Attachment description: WIP: Bug 1917102: Update serde and serde_derive to 1.0.210. → Bug 1917102: Update serde and serde_derive to 1.0.210.
Pushed by egubler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9ece1b16ac44 Update serde and serde_derive to 1.0.210. r=supply-chain-reviewers,webgpu-reviewers,nical,ErichDonGubler https://hg.mozilla.org/integration/autoland/rev/80007d515fb2 Update wgpu crates to c2e0ad293 (2024-09-12). r=supply-chain-reviewers,webgpu-reviewers,nical,ErichDonGubler https://hg.mozilla.org/integration/autoland/rev/002e324329fa test(webgpu): CTS tier promotions and demotions, `backlog` perma changes r=webgpu-reviewers,jimb https://hg.mozilla.org/integration/autoland/rev/6296efe2cc2b test(webgpu): reset contradictory `backlog` results from `try:c75bc73e5301b275d517d7c5ecd47b7ac67e5b37` r=webgpu-reviewers,jimb
Blocks: 1896843
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: