1917186 - [Dedicated Search Button] Pressing ‘ESC’ key twice does not exit searchmode

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Found in

• Nightly 132.0a1;

Affected versions

• Nightly 132.0a1;

Affected platforms

• Ubuntu 22;
• macOS 14;
• Windows 10;

Preconditions

• Have browser.urlbar.scotchBonnet.enableOverride

Steps to reproduce

1. Launch Firefox and open a new tab.
2. Open the Dedicated Search Button and enter searchmode for any search engine.
3. Press Esc key twice.

Expected result

• Searchmode should be dismissed.

Actual result

• Searchmode is not dismissed.

Regression range

• last good: 2024-09-02
• first bad: 2024-09-03
• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3d75e1bf2b01b7d381820d359c8285103300b26a&tochange=00bf44b17240ea469e380823038cc4547993a621
• potentially regressed by: bug 1893071

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1893071

:daleharvey, since you are the author of the regressor, bug 1893071, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1917186 - Escape searchMode when uses presses Esc. r=daisuke

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd4022b53f96
Escape searchMode when uses presses Esc. r=daisuke,urlbar-reviewers

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fd4022b53f96

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-09-06 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 132.0a1 on Windows 10, Ubuntu 22, macOS 14.