1917342 - Synced tabs in the Synced tabs menu are not showing close remote tab feature or inactive tabs due to overflow

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Sammy Khamis [:skhamis]]

Attachment: menu-overflow

Steps to reproduce:

1. Right click toolbar -> Add synced tabs icon to the toolbar
2. Click it to view synced tabs

Expected:

• To see synced tabs look like the avatar and hamburger menu

Actual:
Menu overflows (see attached screenshot) and we do not see the the close remote tab dismiss button or the right arrow for inactive tabs.

This button most likely uses subtly different styling here and should be updated. This happens on Nightly and Beta.

Comment 1

[Sammy Khamis [:skhamis]]

Attachment: image.png

Comment 2

[Sammy Khamis [:skhamis]]

Attachment: Bug 1917342: Fix overflow in remote tabs pane r=#sync-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5b01a928408
Fix overflow in remote tabs pane r=sync-reviewers,desktop-theme-reviewers,sfoster,LougeniaBailey

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d5b01a928408

Comment 5

[Sammy Khamis [:skhamis]]

Attachment: Bug 1917342: Fix overflow in remote tabs pane r=#sync-reviewers

Original Revision: https://phabricator.services.mozilla.com/D221385

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Slightly degraded synced tabs button expereince
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: 1. Add synced tabs icon to the toolbar, 2. Open synced tabs menu (not fxa)
• Risk associated with taking this patch: low
• Explanation of risk level: one line css change
• String changes made/needed: N/A
• Is Android affected?: no

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Slightly degraded synced tabs button experience
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: 1. Add synced tabs icon to the toolbar, 2. Open synced tabs menu (not fxa)
• Risk associated with taking this patch: low
• Explanation of risk level: one line css change
• String changes made/needed: N/A
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/925819d5630a