Closed Bug 1917426 Opened 1 year ago Closed 1 year ago

[win perma] toolkit/components/processtools/tests/xpcshell/test_total_cpu_time.js | test_totalCpuTime_in_parent - [test_totalCpuTime_in_parent : 38] The CPU time reported through Glean should be at least as much as the CPU time reported by ProcInfo ...

Categories

(Thunderbird :: General, defect, P5)

defect

Tracking

(thunderbird_esr128 unaffected, thunderbird132 affected)

RESOLVED FIXED
133 Branch
Tracking Status
thunderbird_esr128 --- unaffected
thunderbird132 --- affected

People

(Reporter: intermittent-bug-filer, Assigned: mkmelin)

References

Details

(Keywords: intermittent-failure, intermittent-testcase, Whiteboard: [stockwell disable-recommended])

Attachments

(1 file)

Component: Add-Ons: General → General

I don't see what would have caused it.
The windows failure is here: https://searchfox.org/comm-central/rev/94a4fb022ccd5586762df7f422be2e01243b6173/mozilla/toolkit/components/processtools/tests/xpcshell/test_total_cpu_time.js#41
"The CPU time reported through Glean should be at least as much as the CPU time reported by ProcInfo before asking Glean for the data - 346 >= 349"
I see a note "50 is an arbitrary value, but the resolution is 16ms on Windows" a few lines below. Could that have some impact here?? Florian, as original creator of this patch, any ideas?

Flags: needinfo?(florian)

(In reply to Magnus Melin [:mkmelin] from comment #4)

I don't see what would have caused it.
The windows failure is here: https://searchfox.org/comm-central/rev/94a4fb022ccd5586762df7f422be2e01243b6173/mozilla/toolkit/components/processtools/tests/xpcshell/test_total_cpu_time.js#41
"The CPU time reported through Glean should be at least as much as the CPU time reported by ProcInfo before asking Glean for the data - 346 >= 349"
I see a note "50 is an arbitrary value, but the resolution is 16ms on Windows" a few lines below. Could that have some impact here?? Florian, as original creator of this patch, any ideas?

This bug feels very similar to bug 1880373, but I don't see why the fixes we landed there wouldn't work on comm-central.

Are you running these tests on real hardware or on virtual machines?
Virtual machines usually don't report having a constant_tsc, which means we can't get a resolution higher than 1/64 s for CPU times on them. There's a hack at https://searchfox.org/mozilla-central/rev/906cf04e249dd79ee496f01f9ed79cc16b1ff78c/toolkit/components/processtools/ProcInfo_win.cpp#61-67 to force using a high resolution in automation. I don't see a reason for that hack to not work on comm-central.

Is there any chance xpc::IsInAutomation could be broken on comm-central? (I assume not, as that would likely break many other things)

Flags: needinfo?(florian)

Are you running these tests on real hardware or on virtual machines?

Rob, do you know?

The test does not fail locally (at least for me).

Flags: needinfo?(rob)

(In reply to Florian Quèze [:florian] from comment #8)

Is there any chance xpc::IsInAutomation could be broken on comm-central? (I assume not, as that would likely break many other things)

I'm pretty sure it's not broken. Using it for something at the moment and it works as expected.

Duplicate of this bug: 1923481

(In reply to Magnus Melin [:mkmelin] from comment #9)

Are you running these tests on real hardware or on virtual machines?

Rob, do you know?

The test does not fail locally (at least for me).

Windows tests run on virtual. It's the same basic "win11-64-2009" image that Firefox tests run on. (No gpu or anything fancy)

Flags: needinfo?(rob)
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/integration/autoland/rev/52b544b6424e Disable test_totalCpuTime_in_parent for Thunderbird. r=florian
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: