1918408 - [css-nesting] Implement the nested declarations rule

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Thomas Wisniewski [:twisniewski]]

We're currently failing these four cases in css/css-nesting/serialize-group-rules-with-decls.html:

• Mixed declarations/rules are on two lines
• Implicit rule is serialized
• Implicit like rule after decls
• Implicit like rule after decls, missing closing braces

Comment 1

[Emilio Cobos Álvarez (:emilio)]

This is the spec change in https://github.com/mozilla/standards-positions/issues/1048 and co.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1918408 - Implement the nested declarations rule. r=dshin!

I didn't put this behind a pref because it was a bit annoying to do with
the parser changes while keeping it fast, and because, at least nesting
wise, this is unlikely to cause compat issues.

There are some complexities for @scope, which I think I got right.

Fixed the tests not to depend on @scope necessarily per the discussion
in https://github.com/web-platform-tests/interop/issues/697.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aa1570bfeca
Implement the nested declarations rule. r=dshin,webidl,smaug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afe296fe7fc7
Fix some DevTools tests and non-unified builds.

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48284 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0aa1570bfeca
https://hg.mozilla.org/mozilla-central/rev/afe296fe7fc7

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Dave Letorey]

Associated Pull Requests

• Content PR
• BCD PR Firefox
• BCD PR Chrome
• Yari PR
• FF Release note PR