Closed
Bug 1918408
Opened 2 months ago
Closed 2 months ago
[css-nesting] Implement the nested declarations rule
Categories
(Core :: CSS Parsing and Computation, enhancement, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
132 Branch
| Tracking | Status | |
|---|---|---|
| firefox132 | --- | fixed |
People
(Reporter: twisniewski, Assigned: emilio)
References
(Blocks 1 open bug, )
Details
(Keywords: dev-doc-complete, Whiteboard: [wpt], [wptsync upstream])
Attachments
(1 file)
We're currently failing these four cases in css/css-nesting/serialize-group-rules-with-decls.html:
- Mixed declarations/rules are on two lines
- Implicit rule is serialized
- Implicit like rule after decls
- Implicit like rule after decls, missing closing braces
|
Assignee | |
Comment 1•2 months ago
|
||
This is the spec change in https://github.com/mozilla/standards-positions/issues/1048 and co.
Assignee: nobody → emilio
Severity: -- → S3
Type: defect → enhancement
Flags: needinfo?(emilio)
Priority: -- → P2
Summary: Failures in WPT /css/css-nesting/serialize-group-rules-with-decls.html → [css-nesting] Implement the nested declarations rule
|
|
Assignee | |
Comment 3•2 months ago
|
||
I didn't put this behind a pref because it was a bit annoying to do with
the parser changes while keeping it fast, and because, at least nesting
wise, this is unlikely to cause compat issues.
There are some complexities for @scope, which I think I got right.
Fixed the tests not to depend on @scope necessarily per the discussion
in https://github.com/web-platform-tests/interop/issues/697.
|
|
Assignee | |
Updated•2 months ago
|
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0aa1570bfeca
Implement the nested declarations rule. r=dshin,webidl,smaug
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/afe296fe7fc7
Fix some DevTools tests and non-unified builds.
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48284 for changes under testing/web-platform/tests
Whiteboard: [wpt] → [wpt], [wptsync upstream]
|
||
Comment 7•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0aa1570bfeca
https://hg.mozilla.org/mozilla-central/rev/afe296fe7fc7
Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox132:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
Upstream PR merged by moz-wptsync-bot
|
|
Assignee | |
Updated•2 months ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•