1919853 - Make DevTools work with CSSNestedDeclarations objects.

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

After bug 1918408, some styles start coming from CSSNestedDeclarations objects. However those aren't returned by InspectorUtils.getCSSStyleRules for example.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1919853 - Make InspectorUtils able to return CSSNestedDeclarations too. r=#devtools-reviewers,#layout-reviewers,#style

Rename getCSSStyleRules now that it can return something else, and
change getCSSStyleRules_starting_style.html to cover this again.

Unfortunately the asserts in ServoStyleRuleMap.cpp no longer hold,
because the style attribute and other declarations are expected not to
show up there.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1919853 - Fix how DevTools deals with bare declarations. r=#devtools-reviewers!

Now that we get CSSNestedDeclarations objects from getMatchedCSSRules(),
undo the workarounds added in bug 1918408, and deal with them in
DevTools somewhat reasonably, and remove the behavior-preserving
workarounds introduced in bug 1918408.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8635b3512ad8
Make InspectorUtils able to return CSSNestedDeclarations too. r=devtools-reviewers,nchevobbe,dshin
https://hg.mozilla.org/integration/autoland/rev/e9455a58a096
Fix how DevTools deals with bare declarations. r=devtools-reviewers,nchevobbe

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad52da9e24b6
Fix non-unified builds.

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/8635b3512ad8
https://hg.mozilla.org/mozilla-central/rev/e9455a58a096
https://hg.mozilla.org/mozilla-central/rev/ad52da9e24b6