1918425 - The drop-down list of the address bar is hidden behind the new tab page when the new sidebar is enabled

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[William Durand [:willdurand]]

Attachment: Screenshot 2024-09-12 at 15.37.52.png

STR

1. Set the sidebar.revamp pref to true
2. Open a new tab
3. Open the urlbar drop-down (e.g. by clicking on it with the mouse)

Expected

The drop-down list is fully visible.

Actual

The drop-down list appears behind the new tab page. Please see the screenshot.

This was caught on today's Nightly.

Comment 2

[Nikki Sharpley (:nikkis) (she/her)]

This is fixed as part of Emilio's work on Bug 1917458. Once that lands, we can close this as resolved.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Since this regressions seems worse than the original issue, would it make sense to partially back out (and reopen) the regressor? Thinking of just removing the:

  /* stylelint-disable-next-line media-query-no-invalid */
  @media (-moz-bool-pref: "sidebar.revamp") {
    .newTabBrowserPanel,
    #sidebar-box {
      /* z-index applied to account for box-shadow cutoff when bookmarks toolbar is present */
      position: relative;
      z-index: 1;
    }

Which is what causes this. Just because bug 1917458 might not get reviewed today.

Comment 5

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1918425 - Revert changes to newTabBrowserPanel and sidebar-box z-index r=#sidebar-reviewers

This was part of the resolution to Bug 1914938, but hid the search drop down results on new tab.
Once Emilio's patch for Bug 1917458 lands, the original bug will be fixed via a different approach.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23cd612ef3f3
Revert changes to newTabBrowserPanel and sidebar-box z-index r=desktop-theme-reviewers,emilio

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/23cd612ef3f3

Comment 10

[Luke Crouch [:groovecoder]]

Attachment: sidebar-vertical-tabs-hides-url-dropdown.png

I still see this bug when I have Sidebar and Vertical tabs both enabled.

Comment 11

[Francesco Lodolo [:flod]]

Indeed, this is broken on nightly (20241003213146). Bug 1922728 was filed and I can confirm address bar is not working.