1922546 - Address bar dropdown covered by page content since horizontal tab strip hidden by vertical tabs

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Kestrel]

Attachment: Address bar dropdown not visible below toolbar

STR:

1. Start with sidebar.verticalTabs = true and sidebar.revamp = true.
2. Click the address bar.

Expected:
Address bar dropdown appears over page content.

Actual:
Dropdown covered by page content.

Occurs on Windows 11 and Ubuntu 24.04.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b17f4d3142eeb0488513b984c8f5113e80101b96&tochange=82dacb5e3821fc0081deed13bd932839d65867e0

Regressed by Bug 1899598.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1899598

:sfoster, since you are the author of the regressor, bug 1899598, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1922546 - Add back the z-index for #navigator-toolbox. r?emilio!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ce46cb64bf0
Add back the z-index for #navigator-toolbox. r=emilio,desktop-theme-reviewers,sidebar-reviewers,nsharpley

Comment 6

[Pascal Chevrel:pascalc]

FYI, I deactivated nightly updates until we have new nightlies with this fix.
I am marking 133 as affected as we do have UI to activate the feature, it's not just an about:config flag, and we are actively asking our nightly population to activate, test and report regressions (thanks Kestrel btw!)

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0ce46cb64bf0

Comment 13

[Francesco Lodolo [:flod]]

On macOS (20241004095321) I can now "see" the dropdown, but it's transparent and not really readable with the bookmarks toolbar enabled. Is that expected?

Comment 14

[Jim Jeffery not reading bug-mail 1/2/11]

Did the bug that caused this issue make it into current release 131 ? There are some reports of people seeing this issue.
See discussion here: https://forums.mozillazine.org/viewtopic.php?p=14985549#p14985549

If so, perhaps the 'fix' can be applied to a . release for 131 ?

Comment 15

[Francesco Lodolo [:flod]]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #14)

Did the bug that caused this issue make it into current release 131 ? There are some reports of people seeing this issue.
See discussion here: https://forums.mozillazine.org/viewtopic.php?p=14985549#p14985549

If so, perhaps the 'fix' can be applied to a . release for 131 ?

This bug happens with vertical tabs enabled, and those are AFAIK not available in release. That user is using userChrome.css, and he knows which code is causing the issue.

Comment 16

[Sam Foster [:sfoster] (he/him)]

Clearing need-info.