1918446 - Switch to tab button disappeared

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect, P2)

Description

[Mandy Cheang [:mcheang][she/her]]

Attachment: bug3-Scotch-Bonnet-PREF-OFF.mov

This seems to be a regression from secondary actions button. The switch to tab button is now in the same style as secondary action buttons. Switching to this new style or enable secondary actions, something had regressed the switch to tab behaviour and functionality.

This bug is happening with browser.urlbar.scotchBonnet.enableOverride PREF true and when it's false.

Steps To Reproduce:

1. Visit https://en.wikipedia.org/wiki/Kitten
2. Open a new tab in the same window.
3. Activate tabs search mode in the address bar for the new tab.
4. Type "kitten".
5. After typing "kitten", there is no switch to tab button from the result shown.
6. When the user clicks on the result, the tab visits the URL instead of switching to the tab (Bug 1918437)

Expected:
See the switch to tab button, and when result is clicked, it should switch to the other tab with the https://en.wikipedia.org/wiki/Kitten webpage.

Actual:
No switch to tab button is shown, and when result is clicked, the browser stayed on the same tab and visited https://en.wikipedia.org/wiki/Kitten

Comment 1

[Dale Harvey (:daleharvey)]

If you have scotchBonnet.enableOveride set to false it looks like you must have browser.urlbar.secondaryActions.featureGate set to true, this switch to tab functionality remains unchanged to me with both of these set to false.

(the scotchBonnet pref will override the value of all sub prefs when enabled, if it is not enabled the sub prefs value decide when they are turned on individually)