1918437 - Switch to tab visits URL instead of switching to tab

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Mandy Cheang [:mcheang][she/her]]

Attachment: bug1.mov

This is a regression from secondary actions button.
This bug is happening with browser.urlbar.scotchBonnet.enableOverride PREF true and when it's false.

Steps To Reproduce:

1. Visit https://en.wikipedia.org/wiki/Kitten
2. Open a new tab in the same window.
3. Activate tabs search mode in the address bar for the new tab.
4. Click the wikipedia kitten switch to tab result
5. After selecting the switch to tab result, the tab visits the URL instead of switching to the tab.

Expected:
Switched to tab with the https://en.wikipedia.org/wiki/Kitten page

Actual:
Stayed on the same tab and visited https://en.wikipedia.org/wiki/Kitten

Comment 1

[Mandy Cheang [:mcheang][she/her]]

Attachment: bug1-PREF-OFF.mov

Comment 2

[Mandy Cheang [:mcheang][she/her]]

I've attached two videos of this bug:

1. when the urlbar.scotchBonnet.enableOverride PREF is TRUE and using @tabs to activate tabs search mode.
2. when the urlbar.scotchBonnet.enableOverride is FALSE and using % to active tabs search mode.

Comment 4

[Mandy Cheang [:mcheang][she/her]]

Attachment: Bug 1918437 - Fix switch to tab to switch tabs and not visit URL. r=daleharvey,mak

Comment 5

[Mandy Cheang [:mcheang][she/her]]

Based on Dale's comments in Bug 1918446, it has not regressed Nightly with the pref off.

When I was testing it with the urlbar.scotchBonnet.enableOverride OFF, the urlbar.secondaryActions.featureGate was ON for me. That's why it seemed like it regressed Nightly, but if secondaryActions is OFF the behaviour is fine and switch to tabs works normally.

However, we still need to fix this and we want switch to tabs working properly before release.
It is still a blocker for Bug 1916679.

Comment 6

[Dale Harvey (:daleharvey)]

Hey Mandy

It looks like we mostly agree that the secondary action that does switch to tab should be remobed and the behaviour reverted back to the current way switch to tab works. Is this something you want to do? Happy to take it over or either way.

Comment 7

[Dale Harvey (:daleharvey)]

Chris mentioned you had some active work at the moment and this is the next bug up for enabling in nightly so I will take it on if thats ok, cheers

Comment 8

[Mandy Cheang [:mcheang][she/her]]

I'm ok with that. Thank you for taking this ticket 👍

Comment 10

[Dale Harvey (:daleharvey)]

Attachment: Bug 1918437 - Disable secondary actions based switch to tab. r=daisuke

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9ff9648c7c5
Disable secondary actions based switch to tab. r=daisuke,desktop-theme-reviewers,urlbar-reviewers,dao

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b9ff9648c7c5

Comment 13

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-09-12 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 133.0a1 on Windows 10, Ubuntu 22, macOS 14.

Comment 14

[Henry Wilkes (they/them) [:henry-x]]

@daleharvey

This patch adds a reference to chrome://browser/content/firefoxview/view-opentabs.svg outside of the firefoxview component, and is used for non-firefoxview stuff (clipboard and switch to tab). Do you think the view-opentabs.svg icon should maybe be moved to browser/themes/shared/icons/ since it is now used for more than firefoxview?

I noticed this in Tor Browser where we're missing the icon because we exclude the firefoxview component from our build. We can patch it ourselves, but I was wondering whether moving the icon makes sense within mozilla-central as well.

Comment 15

[Dale Harvey (:daleharvey)]

Cheers yup that sounds for the best, I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1987279 for it