1918651 - New Switch to tab button container color strips are harder to see on some default browser themes

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: container colors.png

Notes

• The thinner color strips are harder to see on Light theme.
• On Ubuntu the color strips are harder to see on Dark theme whilst hovering.

Found in

• Nightly 132.0a1;

Affected versions

• Nightly 132.0a1;

Affected platforms

• Ubuntu 22;
• macOS 14;
• Windows 10;

Preconditions

• Have browser.urlbar.scotchBonnet.enableOverride set to true

Steps to reproduce

1. Launch Firefox.
2. Open different websites in each container tab( Personal, Shopping, Work, Banking).
3. In a new tab, from the Dedicated Search Button, select ‘Tabs’.
4. Observe the address bar section.
5. Switch to Dark Theme.
6. Open Dedicated Search Button, select ‘Tabs’.
7. Hover over any Switch to tab button.
8. Observe the address bar section.

Expected result

• Corresponding color strips for container tabs should be bolder.

Actual result

• Corresponding color strips for container tabs are narrow and harder to see.

Regression range

• Not a regression.

Comment 1

[Josh Berman]

We can definitely increase the size of the color strips by a couple pixels, but they're really decorative elements so it's not super important they're very visible. Every chiclet has a text label for the container type.

Comment 2

[Chris Bellini (:cbellini)]

The recommended height of the color strip is 4px.

Comment 3

[Chris Bellini (:cbellini)]

Attachment: Switch-to-Tab for Containers

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1918651: Emphasis container color for Switch to tab button

Depends on D224433

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5fd8ef6d023
Emphasis container color for Switch to tab button r=desktop-theme-reviewers,urlbar-reviewers,mak,dao

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f5fd8ef6d023

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-09-13 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 133.0a1 on Windows 10, Ubuntu 22, macOS 14.