1918676 - Vertical tabs: empty spaces in list after closing tabs

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Erwan]

Attachment: Capture d’écran 2024-09-13 154347.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:132.0) Gecko/20100101 Firefox/132.0

Steps to reproduce:

After the update

Actual results:

Closed tabs produce empty space. Certain closed tabs reappear on reopening.

Comment 1

[Dão Gottwald [:dao]]

I suspect this is due to this min-width messing up tab opening and closing animations: https://searchfox.org/mozilla-central/rev/69384e288c285bfd88e8e139211a10f0191f0dfb/browser/themes/shared/tabbrowser/tabs.css#910
We should probably disable these animations in vertical mode, as they don't really make sense there the way they're implemented.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1902083

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1918676 - Disable tab opening / closing animations and tab size locking in vertical mode, properly set --tab-min-width rather than overriding min-width in vertical mode, and restrict some styles to horizontal mode. r=#sidebar-reviewers

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1918676 - [Vertical tabs] Stop clipping the tab-background shadow. r=#sidebar-reviewers

Comment 5

[Phabricator Automation]

Comment on attachment 9424834 [details]
Bug 1918676 - [Vertical tabs] Stop clipping the tab-background shadow. r=#sidebar-reviewers

Revision D222209 was moved to bug 1918638. Setting attachment 9424834 [details] to obsolete.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f973faab6674
Disable tab opening / closing animations and tab size locking in vertical mode, properly set --tab-min-width rather than overriding min-width in vertical mode, and restrict some styles to horizontal mode. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,kcochrane,sclements,dwalker

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1918676, Bug 1918638) for causing browser chrome failures

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=d89CLxZ9Q9uDv8o6qz3bwg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c36ab1469893f7cbfe41b937cc2192ad70fa9097

Log: https://treeherder.mozilla.org/logviewer?job_id=474555907&repo=autoland&lineNumber=27773
https://treeherder.mozilla.org/logviewer?job_id=474556851&repo=autoland&lineNumber=3177
https://treeherder.mozilla.org/logviewer?job_id=474562606&repo=autoland&lineNumber=9574

Backout: https://hg.mozilla.org/integration/autoland/rev/ea2112a8f5a981c48bf4d383b545f77152048964

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d8006baac62
Disable tab opening / closing animations and tab size locking in vertical mode, properly set --tab-min-width rather than overriding min-width in vertical mode, and restrict some styles to horizontal mode. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,kcochrane,sclements,dwalker

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1d8006baac62

Comment 13

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 132.0a1 (2024-09-13) on Windows 10x64. A space will remain after closing an in-between tab while the sidebar is expanded with vertical tabs enabled.
The issue is verified fixed with Firefox 132.0b8 on Windows 10x64, macOS 12 and Ubuntu 24.04. Closing a tab will no longer leave a space.