1918702 - Migrate Services.telemetry.recordEvent calls to Glean APIs

Status: ASSIGNED

(Toolkit :: Telemetry, task)

Description

[Florian Quèze [:florian]]

Similar to how bug 1918226 handles the C++ callers, let's migrate to the Glean APIs the JS code producing legacy telemetry events. This bug is about migrating calls to Services.telemetry.recordEvent to Glean APIs, using GIFFT to ensure the data continues to flow through Legacy Telemetry uninterrupted.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs in toolkit/components/reader, r=chutten.

Comment 2

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for security.doh.settings events, r=chutten.

Depends on D222125

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs in browser/components/sessionstore, r=chutten.

Depends on D222126

Comment 4

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for pictureinpicture.settings, r=chutten.

Depends on D222127

Comment 5

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs in browser/components/BrowserGlue.sys.mjs, r=chutten.

Depends on D222128

Comment 6

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for homepage.preference events, r=chutten.

Depends on D222166

Comment 7

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs in services/fxaccounts/FxAccountsTelemetry.sys.mjs, r=chutten.

Depends on D222167

Comment 8

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for pictureinpicture, r=chutten.

Depends on D222168

Comment 9

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for firefoxview, r=chutten.

Depends on D222409

Comment 10

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for aboutprivatebrowsing, r=chutten.

Depends on D222416

Comment 11

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for browser.migration, r=chutten.

Depends on D222419

Comment 12

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for installation.first_seen, r=chutten.

Comment 13

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for partner_link, r=chutten.

Depends on D222603

Comment 14

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for intl.ui.browserLanguage, r=chutten.

Depends on D222604

Comment 15

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for aboutpreferences.show, r=chutten.

Depends on D222605

Comment 16

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for screenshots, r=chutten.

Depends on D222606

Comment 17

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten.

Depends on D222607

Comment 18

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for doh, r=chutten.

Depends on D222608

Comment 19

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for navigation.search, r=chutten.

Depends on D222631

Comment 20

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for service_request, r=chutten.

Depends on D222631

Comment 21

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for jsonfile.load, r=chutten.

Depends on D222764

Comment 22

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for downloads.added, r=chutten.

Depends on D222765

Comment 23

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs in services/common/uptake-telemetry.sys.mjs, r=chutten.

Depends on D222805

Comment 24

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for sync, r=chutten.

Depends on D222806

Comment 25

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for contextservices.quicksuggest, r=chutten.

Depends on D222807

Comment 26

[Chris H-C :chutten]

Per rpl's replies in this thread in Matrix the extensions.data telemetry events (ones that are manually mirrored) are checked while investigating bugs, not in dashboards or alerts. Luca may r+ a direct removal of the Legacy Telemetry events if presented with one.

On a similar topic, the addonsManager.* events using this recordEvent indirection in AddonManager supply AMO stats and likely have scheduled queries and dashboards looking at them, so removing the Legacy ones requires some deeper thought and planning.

Comment 27

[Florian Quèze [:florian]]

Updating dependencies. We needed to fix:

• Bug 1919894 to fix toolkit/components/passwordmgr/test/unit/test_loginsBackup.js after migrating jsonfile.load ;
• Bug 1800862 to fix the build after migrating screenshots events.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7daf525467a8
Migrate telemetry events to use Glean APIs in toolkit/components/reader, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/f0be4b40549a
Migrate telemetry events to use Glean APIs for security.doh.settings events, r=chutten,settings-reviewers,mconley.
https://hg.mozilla.org/integration/autoland/rev/f9ccb46fb55e
Migrate telemetry events to use Glean APIs in browser/components/sessionstore, r=chutten,sessionstore-reviewers,dao.
https://hg.mozilla.org/integration/autoland/rev/0a507f23dcc5
Migrate telemetry events to use Glean APIs for pictureinpicture.settings, r=chutten,settings-reviewers,pip-reviewers,firefox-desktop-core-reviewers ,mconley.
https://hg.mozilla.org/integration/autoland/rev/e4c9e88ef3e7
Migrate telemetry events to use Glean APIs in browser/components/BrowserGlue.sys.mjs, r=chutten,firefox-desktop-core-reviewers ,mconley.
https://hg.mozilla.org/integration/autoland/rev/822ab2bd102c
Migrate telemetry events to use Glean APIs for homepage.preference events, r=chutten,extension-reviewers,robwu.
https://hg.mozilla.org/integration/autoland/rev/4b885437599a
Migrate telemetry events to use Glean APIs in services/fxaccounts/FxAccountsTelemetry.sys.mjs, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/bda4ffe663a5
Migrate telemetry events to use Glean APIs for pictureinpicture, r=chutten,pip-reviewers,mconley.
https://hg.mozilla.org/integration/autoland/rev/ef1e290bf73c
Migrate telemetry events to use Glean APIs for firefoxview, r=chutten,fxview-reviewers,jsudiaman.
https://hg.mozilla.org/integration/autoland/rev/ce616ea7bbd2
Migrate telemetry events to use Glean APIs for aboutprivatebrowsing, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/18588e1ad1f8
Migrate telemetry events to use Glean APIs for browser.migration, r=chutten,migration-reviewers,mconley.
https://hg.mozilla.org/integration/autoland/rev/7cba66b23e03
Migrate telemetry events to use Glean APIs for installation.first_seen, r=chutten,nalexander.
https://hg.mozilla.org/integration/autoland/rev/5a41d171f33a
Migrate telemetry events to use Glean APIs for partner_link, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/46b5da24e91f
Migrate telemetry events to use Glean APIs for intl.ui.browserLanguage, r=chutten,settings-reviewers,mossop.
https://hg.mozilla.org/integration/autoland/rev/e1dfa6aa0387
Migrate telemetry events to use Glean APIs for aboutpreferences.show, r=chutten,settings-reviewers,mossop.
https://hg.mozilla.org/integration/autoland/rev/f4b81ca4ad85
Migrate telemetry events to use Glean APIs for screenshots, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/68d8da19ce6d
Migrate telemetry events to use Glean APIs for doh, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/7b6d764c0753
Migrate telemetry events to use Glean APIs for service_request, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/f976178c4249
Migrate telemetry events to use Glean APIs for jsonfile.load, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/21a19a14ccdf
Migrate telemetry events to use Glean APIs for downloads.added, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/0cc18c7a9f5d
Migrate telemetry events to use Glean APIs in services/common/uptake-telemetry.sys.mjs, r=chutten.

Comment 29

[Florian Quèze [:florian]]

Attachment: Bug 1918702 - Migrate telemetry events to use Glean APIs for normandy, r=chutten.

Depends on D222808

Comment 30

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_uptake_telemetry.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/448c0d6eacbc5768aedafb58018f268083723cc3

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | services/common/tests/unit/test_uptake_telemetry.js

Comment 31

[Florian Quèze [:florian]]

Attachment: WIP: Bug 1918702 - fix test_uptake_telemetry.js

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7021aba4780
Migrate telemetry events to use Glean APIs in toolkit/components/reader, r=chutten. CLOSED TREE
https://hg.mozilla.org/integration/autoland/rev/42f98641ab22
fix test_uptake_telemetry.js CLOSED TREE

Comment 33

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d7021aba4780
https://hg.mozilla.org/mozilla-central/rev/42f98641ab22