1920230 - Migrate Services.telemetry.recordEvent calls in AutofillTelemetry.sys.mjs to Glean APIs

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

bug 1834570 migrated creditcard.{detected|popup_shown|filled|filled_modified|submitted|cleared}#cc_form_v2 from Legacy Telemetry to Glean... but left the legacy event in place.

In bug 1906292 autofilling gained the ability to work across iframes, and gained a Glean formautofill.iframe_layout_detection event without a corresponding Legacy Telemetry event.

As part of the deprecation of Legacy Telemetry event recording APIs, we need to figure out how to properly handle the Legacy Telemetry events in AutofillTelemetry.

We can semi-mechanically mirror all existing Legacy Telemetry events using GIFFT and Glean APIs, but since creditcard.cc_form_v2 was manually migrated already to formautofill.creditcards.* last August, maybe now we can remove the remaining Legacy Telemetry events? Dimi, what do you say?

And as for non-creditcard autofill Legacy Telemetry events, would it be fair to assume that you'd like them to continue to be instrumented for the foreseeable future?

Comment 1

[Dimi Lee [:dimi]]

(In reply to Chris H-C :chutten from comment #0)

bug 1834570 migrated creditcard.{detected|popup_shown|filled|filled_modified|submitted|cleared}#cc_form_v2 from Legacy Telemetry to Glean... but left the legacy event in place.

If i remember correctly, :janika told me we can't use mirror for that cc_form_v2 telemetry, but i forget why.

As part of the deprecation of Legacy Telemetry event recording APIs, we need to figure out how to properly handle the Legacy Telemetry events in AutofillTelemetry.

We can semi-mechanically mirror all existing Legacy Telemetry events using GIFFT and Glean APIs, but since creditcard.cc_form_v2 was manually migrated already to formautofill.creditcards.* last August, maybe now we can remove the remaining Legacy Telemetry events? Dimi, what do you say?

Yes, the cc_form_v2 Legacy Telemetry can be removed. As for creditcard.doorhanger and creditcard.manage, I think we should still migrate them to glean. Will that be handled in Bug 1918702?

And as for non-creditcard autofill Legacy Telemetry events, would it be fair to assume that you'd like them to continue to be instrumented for the foreseeable future?

I assume you meant address-related telemetry events?? If yes, then yes, they should continue to be instrumented. Is there any action item for our team?

Comment 2

[Chris H-C :chutten]

(In reply to Dimi Lee [:dimi] from comment #1)

(In reply to Chris H-C :chutten from comment #0)

bug 1834570 migrated creditcard.{detected|popup_shown|filled|filled_modified|submitted|cleared}#cc_form_v2 from Legacy Telemetry to Glean... but left the legacy event in place.

If i remember correctly, :janika told me we can't use mirror for that cc_form_v2 telemetry, but i forget why.

It might've been because the extra keys weren't of a format that glean_parser would accept (which we've now fixed as of bug 1910976).

Yes, the cc_form_v2 Legacy Telemetry can be removed. As for creditcard.doorhanger and creditcard.manage, I think we should still migrate them to glean. Will that be handled in Bug 1918702?

And as for non-creditcard autofill Legacy Telemetry events, would it be fair to assume that you'd like them to continue to be instrumented for the foreseeable future?

I assume you meant address-related telemetry events?? If yes, then yes, they should continue to be instrumented. Is there any action item for our team?

Yes, those are the ones I meant. We'll take care of migrating them so they continue to be sent via Legacy Telemetry while also being sent via Glean. I intend to take care of that in this bug. The only action for your team will be to review the patch once I've prepared it : )

Comment 3

[Dimi Lee [:dimi]]

(In reply to Chris H-C :chutten from comment #2)

It might've been because the extra keys weren't of a format that glean_parser would accept (which we've now fixed as of bug 1910976).

ah indeed, thank you for the information!

Yes, those are the ones I meant. We'll take care of migrating them so they continue to be sent via Legacy Telemetry while also being sent via Glean. I intend to take care of that in this bug. The only action for your team will be to review the patch once I've prepared it : )

Awesome! Really appreciate for your help! I'll do my best to review those patches :)

Comment 4

[Chris H-C :chutten]

Attachment: Bug 1920230 - Migrate Legacy Telemetry autofill events to Glean r?florian!,dimi!

This includes:

• Remove legacy creditcard.cc_form_v2 events. (They're no longer used)
• Migrate autofill doorhanger events to Glean
• Migrate {address|creditcard}.*#manage events to Glean
• Migrate address.address_form* events to Glean

Comment 5

[Dimi Lee [:dimi]]

(In reply to Chris H-C :chutten from comment #4)

This includes:

• Remove legacy creditcard.cc_form_v2 events. (They're no longer used)

Hi Chris, thank you for working on the patch!!!
I would like to confirm that after migrating to glean, whether we will need to rewrite the query in re-dash, i guess the answer is yes?
If yes, I would like to know whether we can delay removing this metrics (cc_form_v2). The reason is because this metric is very critical and a lot of queries in our dashboard are based on it. The PM of our team is also using those metrics to plan the roadmap for the next year at this point.
Is there a due day to remove all the legacy telemetry?!

Comment 6

[Chris H-C :chutten]

Oh, I thought you said in comment #1 that the legacy creditcard.{detected|popup_shown|filled|filled_modified|submitted|cleared}#cc_form_v2 events are no longer used since the introduction of the Glean events in bug 1834570?

I will happily retain the legacy events and mirror to them using additional Glean events if they're still in use. Just let me know what you need.

As for a due day: the sooner the better. We can't remove the APIs until all existing uses are gone. And so long as the APIs remain, there's the possibility that someone will try and use them, despite them being deprecated in the docs.

Comment 7

[Dimi Lee [:dimi]]

(In reply to Chris H-C :chutten from comment #6)

Oh, I thought you said in comment #1 that the legacy creditcard.{detected|popup_shown|filled|filled_modified|submitted|cleared}#cc_form_v2 events are no longer used since the introduction of the Glean events in bug 1834570?

ya, 'm sorry, it was my bad that i thought we also ported our query to use glean data after fixing Bug 1834570, but i found out i was wrong after taking a closer look.

I will happily retain the legacy events and mirror to them using additional Glean events if they're still in use. Just let me know what you need.

That will be great if we can create another glean event and mirror the data, thank you!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a362878a4f03
Migrate Legacy Telemetry autofill events to Glean r=florian,dimi

Comment 9

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/a362878a4f03