Closed Bug 1918706 Opened 2 months ago Closed 1 month ago

[Outreachy] Update test262 and test262 skipped files

Categories

(Core :: JavaScript: Standard Library, task, P3)

Product:
Core
Component:
JavaScript: Standard Library
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox133 --- fixed

People

(Reporter: dminor, Assigned: syedbarimanjan, Mentored)

References

Details

Attachments

(1 file)

Bug 1918706 - Update test262 tests; r=dminor!
48 bytes, text/x-phabricator-request
Details | Review

We use test262 as a source of tests to make sure that SpiderMonkey has implemented the JavaScript standard correctly. New tests are added all the time, so we want to do updates to make sure we have the latest tests. We sometimes have to skip tests, because they test features that have not yet been implemented in SpiderMonkey. We use jstests.list to handle this.

To update the tests:

  1. Make sure that you are able to build SpiderMonkey and run the existing tests. There are instructions here. You want to run the jstests, using this command ./mach jstests.
  2. Then run the update script.
  3. Rerun the jstests, making a note of any new failures.
  4. Add the new failures to the list of skipped tests in jstests.list.
  5. Once the tests all pass for you, you can commit your changes. Your commit message should look like: Bug X - Update test262 tests; r=dminor!, where X is the number for this bug.
  6. Once you have your changes committed, request review. There are instructions on using phabricator and on getting reviews.
Severity: -- → N/A
Priority: -- → P3

:dminor, I tested this and all of the tests are passing after running the update script.

jstests.list is up to date with test262, hence no test failed.

Are there any changes to the tests themselves? I think someone did an update recently, so perhaps no new tests have been added?

(In reply to Dan Minor [:dminor] from comment #3)

Are there any changes to the tests themselves? I think someone did an update recently, so perhaps no new tests have been added?

Yes, I noticed an increment after I updated and rerun the jstests, but none of tests failed

It still makes sense to update the tests, even if there are no new failures, because that will help prevent future regressions.

Assignee: nobody → syedbarimanjan
Status: NEW → ASSIGNED

Backed out for causing SM bustages on PlainDateTime.cpp

[task 2024-10-03T19:11:19.852Z] TEST-PASS | test262/built-ins/Temporal/Duration/prototype/total/unit-plurals-accepted.js | (args: "--dll /builds/worker/fetches/injector/libbreakpadinjector.so") [0.0 s]
[task 2024-10-03T19:11:19.856Z] ## test262/built-ins/Temporal/Duration/prototype/total/relativeto-string-limits.js: rc = -11, run time = 0.060275
[task 2024-10-03T19:11:19.856Z] [18463] Assertion failure: ISODateTimeWithinLimits(one), at /builds/worker/checkouts/gecko/js/src/builtin/temporal/PlainDateTime.cpp:921
[task 2024-10-03T19:11:19.856Z] #01: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x2e53610]
[task 2024-10-03T19:11:19.856Z] #02: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x2e39d19]
[task 2024-10-03T19:11:19.856Z] #03: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x2e35cc8]
[task 2024-10-03T19:11:19.856Z] #04: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x1a5bc95]
[task 2024-10-03T19:11:19.856Z] #05: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x1a5b232]
[task 2024-10-03T19:11:19.856Z] #06: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x1a6c424]
[task 2024-10-03T19:11:19.856Z] #07: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x1a5a5d8]
[task 2024-10-03T19:11:19.856Z] #08: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x1a5e63c]
[task 2024-10-03T19:11:19.856Z] #09: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x1a5ec40]
[task 2024-10-03T19:11:19.856Z] #10: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x1bf7b22]
[task 2024-10-03T19:11:19.856Z] #11: JS_ExecuteScript(JSContext*, JS::Handle<JSScript*>)[/builds/worker/workspace/obj-spider/dist/bin/js +0x1bf7d2c]
[task 2024-10-03T19:11:19.857Z] #12: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x19fdaef]
[task 2024-10-03T19:11:19.857Z] #13: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x19fcdfa]
[task 2024-10-03T19:11:19.857Z] #14: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x19950a9]
[task 2024-10-03T19:11:19.857Z] #15: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x198cb3b]
[task 2024-10-03T19:11:19.857Z] #16: ???[/lib/x86_64-linux-gnu/libc.so.6 +0x2718a]
[task 2024-10-03T19:11:19.857Z] #17: __libc_start_main[/lib/x86_64-linux-gnu/libc.so.6 +0x27245]
[task 2024-10-03T19:11:19.857Z] #18: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x197e549]
[task 2024-10-03T19:11:19.857Z] #19: ??? (???:???)
[task 2024-10-03T19:11:19.857Z] TEST-UNEXPECTED-FAIL | test262/built-ins/Temporal/Duration/prototype/total/relativeto-string-limits.js | (args: "--dll /builds/worker/fetches/injector/libbreakpadinjector.so") [0.1 s]
[task 2024-10-03T19:11:19.857Z] TEST-PASS | test262/built-ins/Temporal/Duration/prototype/total/unit-plurals-accepted.js | (args: "--dll /builds/worker/fetches/injector/libbreakpadinjector.so --baseline-eager --write-protect-code=off") [0.0 s]
[task 2024-10-03T19:11:19.862Z] ## test262/built-ins/Temporal/Duration/prototype/total/relativeto-string-limits.js: rc = -11, run time = 0.05856
[task 2024-10-03T19:11:19.863Z] [18492] Assertion failure: ISODateTimeWithinLimits(one), at /builds/worker/checkouts/gecko/js/src/builtin/temporal/PlainDateTime.cpp:921
[task 2024-10-03T19:11:19.863Z] #01: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x2e53610]
[task 2024-10-03T19:11:19.863Z] #02: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x2e39d19]
[task 2024-10-03T19:11:19.863Z] #03: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x2e35cc8]
[task 2024-10-03T19:11:19.863Z] #04: ??? (???:???)
[task 2024-10-03T19:11:19.863Z] TEST-UNEXPECTED-FAIL | test262/built-ins/Temporal/Duration/prototype/total/relativeto-string-limits.js | (args: "--dll /builds/worker/fetches/injector/libbreakpadinjector.so --baseline-eager --write-protect-code=off") [0.1 s]
[task 2024-10-03T19:11:19.871Z] TEST-PASS | test262/built-ins/Temporal/Duration/prototype/total/precision-exact-mathematical-values-7.js | (args: "--dll /builds/worker/fetches/injector/libbreakpadinjector.so") [0.0 s]
[task 2024-10-03T19:11:19.881Z] ## test262/built-ins/Temporal/Duration/prototype/total/relativeto-string-limits.js: rc = -11, run time = 0.079732
[task 2024-10-03T19:11:19.881Z] [18490] Assertion failure: ISODateTimeWithinLimits(one), at /builds/worker/checkouts/gecko/js/src/builtin/temporal/PlainDateTime.cpp:921
[task 2024-10-03T19:11:19.881Z] #01: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x2e53610]
[task 2024-10-03T19:11:19.881Z] #02: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x2e39d19]
[task 2024-10-03T19:11:19.881Z] #03: ???[/builds/worker/workspace/obj-spider/dist/bin/js +0x2e35cc8]
[task 2024-10-03T19:11:19.881Z] #04: ??? (???:???)
[task 2024-10-03T19:11:19.881Z] TEST-UNEXPECTED-FAIL | test262/built-ins/Temporal/Duration/prototype/total/relativeto-string-limits.js | (args: "--dll /builds/worker/fetches/injector/libbreakpadinjector.so --ion-eager --ion-offthread-compile=off --more-compartments") [0.1 s]
[task 2024-10-03T19:11:19.881Z] TEST-PASS | test262/built-ins/Temporal/Duration/prototype/total/unit-plurals-accepted.js | (args: "--dll /builds/worker/fetches/injector/libbreakpadinjector.so --ion-eager --ion-offthread-compile=off --more-compartments") [0.1 s]
Flags: needinfo?(syedbarimanjan)

:dminor, I reran the tests and they are still all passing on my machine. Can you point me to where i can look into this.

Flags: needinfo?(syedbarimanjan) → needinfo?(dminor)

It's because these are test failures with temporal, which is not part of the default built configuration. You should be able to add
ac_add_options --with-temporal-api to your mozconfig to trigger these failures (see https://searchfox.org/mozilla-central/source/js/moz.configure#1359).

Make sure you have ac_add_options --enable-debug as well, without this you won't see assertion failures.

If you have problems getting the temporal build working, let me know, you can add find the failing tests on the CI job and add them to jstests.list by hand, and I can test it for you using my machine.

Flags: needinfo?(dminor)

:dminor, I have updated the list with the failing tests.

Flags: needinfo?(dminor)

https://hg.mozilla.org/mozilla-central/rev/fc8587d061e5

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
See Also: → 1923883
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: