1923883 - Assertion failures in PlainDateTime.cpp after updating Test262

Status: NEW

(Core :: JavaScript Engine, defect, P3)

Description

[Syed Bariman Jan]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36

Steps to reproduce:

Tests failing after running test262-update.py script

Actual results:

https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=ckFMTFjZT7yqqk5MaEuM9w.0&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=25e197bc4c13fafb71ca09fcb82c3d10c023916c&searchStr=Linux%2Cx64%2Cdebug%2CSpidermonkey%2Cbuilds%2Cspidermonkey-sm-temporal-linux64%2Fdebug%2Ctemporal

Expected results:

All tests should have passed

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

So, after updating, you'll want to also add the appropriate test skipping

Some of this temporal stuff is in flight, but if you provide your own skips that's OK. I would land this update with the feature you are trying to add support to.

Comment 2

[Syed Bariman Jan]

(In reply to Matthew Gaudet (he/him) [:mgaudet] from comment #1)

So, after updating, you'll want to also add the appropriate test skipping

Some of this temporal stuff is in flight, but if you provide your own skips that's OK. I would land this update with the feature you are trying to add support to.

I have added the tests skipping and have mentioned this issue in jstests.list too so when somone is working on fixing them they can refernce it.

Comment 3

[Dan Minor [:dminor]]

I think these are now failing because the temporal spec has tightened up the range of dates that it is willing to calculate values for. We have a problem where ICU4X is asserting on values that were considered valid by Temporal.

These failures resulted from just updating test262 with no other changes, so we need to update our Temporal implementation.

Syed added the test skipping as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1918706

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Ah, that wasn't clear!