1918734 - [Outreachy] Add preference for Math.sumPrecise proposal

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Dan Minor [:dminor]]

The first step to implementing at TC39 proposal in SpiderMonkey is to add a preference for it. This allows for the feature to be enabled or disabled at runtime, which is important, because we don't want to enable a feature by default until we've tested it enough to be confident that it won't cause problems for our users.

This bug is about adding a preference for the Math.sumPrecise proposal. The steps to do this are:

1. Make sure that you are able to build SpiderMonkey and run the existing tests. There are instructions here. You want to run the jstests, using this command ./mach jstests.
2. Find the section in StaticPrefList.yaml for SpiderMonkey preferences and make a copy of an existing preference. Make sure your copy is inside the #ifdef NIGHTLY_BUILD ... #endif // NIGHTLY_BUILD section, because we only want this to be available on nightly builds to begin with.
3. Change the copy so that the preference name is javascript.options.experimental.math_sumprecise and save your changes.
4. Similarly, add an option for the JavaScript shell, by making a copy of this example and changing promise-try to math-sumprecise.
5. Make sure you can still build and run the tests.
6. Once the tests all pass for you, you can commit your changes. Your commit message should look like: Bug X - Add preference for Math.sumPrecise proposal; r=dminor!, where X is the number for this bug.
7. Once you have your changes committed, request review. There are instructions on using phabricator and on getting reviews.

Comment 1

[Syed Bariman Jan]

Hi I would like to work on this, can i get assigned to the issue.

Comment 2

[Dan Minor [:dminor]]

Thank you for your interest :) I'll assign the issue to you once you have patches ready for review.

Comment 3

[Syed Bariman Jan]

Attachment: Bug 1918734 - Add preference for Math.sumPrecise proposal; r=dminor!

Comment 4

[Dan Minor [:dminor]]

This looks good, thank you for your contribution. I've created a follow up in Bug 1922523 if you are interested in continuing to work on sumPrecise :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/622bd6b0c264
Add preference for Math.sumPrecise proposal; r=dminor

Comment 6

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/622bd6b0c264