1922523 - [Outreachy] Add placeholder implementation for Math.sumPrecise proposal

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Dan Minor [:dminor]]

This bug is about adding a placeholder implementation for the Math.sumPrecise proposal. The steps to do this are:

1. Make sure that you are able to build SpiderMonkey and run the existing tests. There are instructions here. You want to run the jstests, using this command ./mach jstests.
2. In the jsmath.cpp add a placeholder method for sumPrecise. We use NIGHTLY_BUILD so this will only be built for Nightly, and will not be available in release. Returning false means this method will fail all the time for now.

#ifdef NIGHTLY_BUILD
static bool math_sumprecise(JSContext* cx, unsigned argc, Value* vp) {
  return false;
}
#endif

3. We also need to add it to the list of methods on the Math object, right at the end of the list. There's an example of how to do this in this patch.
4. The final step is to remove it from the Math object when the pref is not enabled. There's an example of how to do this in this patch as well.
5. Make sure you can still build and run the tests.
6. Once the tests all pass for you, you can commit your changes. Your commit message should look like: Bug X - Add placeholder for Math.sumPrecise proposal; r=dminor!, where X is the number for this bug.
7. Once you have your changes committed, request review. There are instructions on using phabricator and on getting reviews.

Comment 1

[Syed Bariman Jan]

:dminor, I am working on this.

Comment 2

[Syed Bariman Jan]

Attachment: Bug 1922523 - Add placeholder for Math.sumPrecise proposal; r=dminor!

Comment 3

[Syed Bariman Jan]

Attachment: Bug 1922523 - Add placeholder for Math.sumPrecise proposal; r=dminor!

Comment 4

[Syed Bariman Jan]

Attachment: Bug 1922523 - Add placeholder for Math.sumPrecise proposal; r=dminor!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b26745c93182
Add placeholder for Math.sumPrecise proposal; r=dminor

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b26745c93182