Closed Bug 1919161 Opened 1 months ago Closed 17 days ago

[Toolbar Redesign] Fix the touch the target size of the navigation and menu buttons for the landscape and portait version of the toolbar.

Categories

(Fenix :: Toolbar, task, P2)

All
Android
task

Tracking

(firefox133 fixed)

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: tchoh, Assigned: tchoh)

References

(Blocks 1 open bug)

Details

(Whiteboard: [kitkat banana sprint][fxdroid][group3])

Attachments

(2 files)

Figma Link: https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/Toolbar-Redesign?node-id=18304-352944&t=ur7cBuPjAOXTzif6-4

This is supposed to be focused around modifying the touch size and item size for Navigation buttons (back and forward) and the menu button on the toolbar.
This SHOULD impact the original Toolbar as well as the toolbar redesign. This SHOULD NOT impact Focus.

Assignee: nobody → tchoh
Status: NEW → ASSIGNED
Blocks: 1919157

Based on an offline conversation, modifying the old Toolbar is acceptable.

Attached image image.png

Since the ticvket is about "touch targets" using Accessibility Scanner I see issues with

  • the security indicator (40dp x 40dp)
  • display toolbar (height 40dp)
  • new tab button (34dp x 34dp)
  • tab counter button (34dp x 34dp)
  • the menu button (only in landscape) (width 36dp)

Increasing the height/width to fix these would result in a layout change - a visible difference.
To avoid this we have helper methods like increaseTapArea & increaseTapAreaVertically (note that for a parent view there can only be one touch delegate - we might need a compound one that would support increasing the touch area for more children instead of just for one like we currently support).

Summary: [Toolbar Redesign] Fix the touch the target size of the buttons for the landscape and portait version of the toolbar. → [Toolbar Redesign] Fix the touch the target size of the navigation and menu buttons for the landscape and portait version of the toolbar.

updated the name of the ticket and will follow up with Aarjav offline to address the comment left by Petru regarding the other touch targets.

Blocks: 1920554

Spoke with Aarjav and Petru offline, the a11y changes will be handled in another ticket https://bugzilla.mozilla.org/show_bug.cgi?id=1920554

Aarjav says the touch target size fixes should block toolbar release, but don't need to block beta.

Severity: -- → N/A
Priority: -- → P2
No longer blocks: 1919157
No longer depends on: 1909751
See Also: → 1919157, 1909751
Whiteboard: [kitkat banana sprint] → [kitkat banana sprint][fxdroid][group3]
Depends on: 1919157
See Also: 1919157
No longer depends on: 1919157

Aarjav says touch target sizes should be 48*48 minimum for all tappable icons and surfaces, as detailed here: https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/__-Toolbar-Redesign?node-id=18304-352944&node-type=section&t=EQ6MyE0KvQI9JlPl-0

Blocks: 1924143
Pushed by tchoh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/caacbe097229 update Toolbar button touch targets r=android-reviewers,skhan,petru
Status: ASSIGNED → RESOLVED
Closed: 17 days ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: