1919161 - [Toolbar Redesign] Fix the touch the target size of the navigation and menu buttons for the landscape and portait version of the toolbar.

Status: RESOLVED FIXED

(Fenix :: Toolbar, task, P2)

Description

[tchoh]

Figma Link: https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/Toolbar-Redesign?node-id=18304-352944&t=ur7cBuPjAOXTzif6-4

This is supposed to be focused around modifying the touch size and item size for Navigation buttons (back and forward) and the menu button on the toolbar.
This SHOULD impact the original Toolbar as well as the toolbar redesign. This SHOULD NOT impact Focus.

Comment 1

[tchoh]

Attachment: Bug 1919161 - update Toolbar button touch targets

Comment 2

[tchoh]

Based on an offline conversation, modifying the old Toolbar is acceptable.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: image.png

Since the ticvket is about "touch targets" using Accessibility Scanner I see issues with

• the security indicator (40dp x 40dp)
• display toolbar (height 40dp)
• new tab button (34dp x 34dp)
• tab counter button (34dp x 34dp)
• the menu button (only in landscape) (width 36dp)

Increasing the height/width to fix these would result in a layout change - a visible difference.
To avoid this we have helper methods like increaseTapArea & increaseTapAreaVertically (note that for a parent view there can only be one touch delegate - we might need a compound one that would support increasing the touch area for more children instead of just for one like we currently support).

Comment 4

[tchoh]

updated the name of the ticket and will follow up with Aarjav offline to address the comment left by Petru regarding the other touch targets.

Comment 5

[tchoh]

Spoke with Aarjav and Petru offline, the a11y changes will be handled in another ticket https://bugzilla.mozilla.org/show_bug.cgi?id=1920554

Comment 6

[Chris Peterson [:cpeterson]]

Aarjav says the touch target size fixes should block toolbar release, but don't need to block beta.

Comment 7

[Chris Peterson [:cpeterson]]

Aarjav says touch target sizes should be 48*48 minimum for all tappable icons and surfaces, as detailed here: https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/__-Toolbar-Redesign?node-id=18304-352944&node-type=section&t=EQ6MyE0KvQI9JlPl-0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/caacbe097229
update Toolbar button touch targets r=android-reviewers,skhan,petru

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/caacbe097229