1909751 - [Toolbar Redesign] Fix the margins for the landscape version of the toolbar.

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P2)

Description

[Aarjav [:aarjav]]

Figma Link: https://www.figma.com/design/8fsCvtnweBkWGZ9NfL907l/Toolbar-Redesign?node-id=18304-352944&t=ur7cBuPjAOXTzif6-4

Comment 1

[tchoh]

Attachment: Bug 1909751 - modified margins for tablet display toolbar

Comment 2

[Aarjav [:aarjav]]

This bug doesn't need to stay behind the 'redesign' flag. We can push this to release.
What changes?

• As mentioned in the Figma link above, the landscape version of the toolbar should have a margin of 16 dp.
• The back, forward, new tab, tab tray icon and menu icons should have a touch target size of 48*48 dp.

Comment 3

[tchoh]

There's discrepancy between the figma designs. There is requirement text that shows 24 dp margins, but the designs show 16 dp margins.

Comment 4

[tchoh]

Attachment: Bug 1909751 - Adjust margins for Toolbar

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cd3d5e17a56
Adjust margins for Toolbar r=android-reviewers,Roger

Comment 6

[Atila Butkovits]

Backed out for causing linting failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/4de147ab8ffb010e10b3cfc1d312bb0d22d507a6

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7cd3d5e17a56b7e5df46a2ddd41a5bcb16f7042b&selectedTaskRun=JWVWBLbgR5qC58g-SJ7anQ.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=474845640&repo=autoland
https://treeherder.mozilla.org/logviewer?job_id=474845641&repo=autoland&lineNumber=23932

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec4d81c2e036
Adjust margins for Toolbar r=android-reviewers,Roger

Comment 8

[Norisz Fay [:noriszfay]]

Backed out for causing fenix lint failure related to R.dimen.browser_fragment_display_toolbar_padding

Backout link

Push with failures

Failure log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/400dd78f97fc
Adjust margins for Toolbar r=android-reviewers,Roger

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/400dd78f97fc

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e4cfec46cee6

Comment 12

[Donal Meehan [:dmeehan]]

Backed out of beta for causing Bug 1930236
https://hg.mozilla.org/releases/mozilla-beta/rev/e4cfec46cee6

Comment 13

[Rob Wu [:robwu]]

This was also backed out of m-c (135) by https://hg.mozilla.org/mozilla-central/rev/144d526a18c6 to resolve bug 1930236 (the same bug as in comment 12).