Closed Bug 1909751 Opened 3 months ago Closed 28 days ago

[Toolbar Redesign] Fix the margins for the landscape version of the toolbar.

Categories

(Fenix :: Toolbar, task, P2)

All
Android
task

Tracking

(firefox133 fixed)

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: aarjav, Assigned: tchoh)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [kitkat banana sprint])

Attachments

(1 file, 1 obsolete file)

Summary: [Toolbar Redesign] Fix the margins and touch the target size of the buttons for the landscape version of the toolbar. → [Toolbar Redesign] Fix the margins of the toolbar and touch the target size of the buttons for the landscape version of the toolbar.
Severity: -- → N/A
Priority: -- → P2
Assignee: nobody → tchoh
Status: NEW → ASSIGNED
Whiteboard: [kitkat banana sprint]

This bug doesn't need to stay behind the 'redesign' flag. We can push this to release.
What changes?

  • As mentioned in the Figma link above, the landscape version of the toolbar should have a margin of 16 dp.
  • The back, forward, new tab, tab tray icon and menu icons should have a touch target size of 48*48 dp.
Attachment #9423337 - Attachment is obsolete: true

There's discrepancy between the figma designs. There is requirement text that shows 24 dp margins, but the designs show 16 dp margins.

Blocks: 1919161
Summary: [Toolbar Redesign] Fix the margins of the toolbar and touch the target size of the buttons for the landscape version of the toolbar. → [Toolbar Redesign] Fix the margins for the landscape version of the toolbar.
Pushed by tchoh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7cd3d5e17a56 Adjust margins for Toolbar r=android-reviewers,Roger
Pushed by tchoh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec4d81c2e036 Adjust margins for Toolbar r=android-reviewers,Roger

Backed out for causing fenix lint failure related to R.dimen.browser_fragment_display_toolbar_padding

Backout link

Push with failures

Failure log

Flags: needinfo?(tchoh)
No longer blocks: 1919161
See Also: → 1919161
Pushed by tchoh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/400dd78f97fc Adjust margins for Toolbar r=android-reviewers,Roger
Status: ASSIGNED → RESOLVED
Closed: 28 days ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Regressions: 1923115
Blocks: 1924143
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: